Skip to content

Commit 2f9c5cd

Browse files
Saumya40-codesyurishkuro
authored andcommitted
[receiver/jaegerreceiver] Add logs when the respective server starts in jaegerreceiver (open-telemetry#36961)
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description - This PR adds the logging related to the server starting under the [jaegerreceiver](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/receiver/jaegerreceiver) - Added logs when: GRPC, Thrift Http, Thrift Binary and Thrift compact server starts <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes jaegertracing/jaeger#6412 #### How was change tested? Running collector with `jaegerreceiver` enabled with its all transports #### Output ``` @Saumya40-codes ➜ /workspaces/opentelemetry-collector-contrib (log-endpoints) $ ./bin/otelcontribcol_linux_amd64 --config config.yaml 2024-12-27T15:37:23.428Z info [email protected]/service.go:164 Setting up own telemetry... 2024-12-27T15:37:23.428Z info telemetry/metrics.go:70 Serving metrics {"address": "localhost:8888", "metrics level": "Normal"} 2024-12-27T15:37:23.428Z info builders/builders.go:26 Development component. May change in the future. {"kind": "exporter", "data_type": "traces", "name": "debug"} 2024-12-27T15:37:23.436Z info [email protected]/service.go:230 Starting otelcontribcol... {"Version": "0.116.0-dev", "NumCPU": 2} 2024-12-27T15:37:23.436Z info extensions/extensions.go:39 Starting extensions... 2024-12-27T15:37:23.436Z info [email protected]/trace_receiver.go:252 Starting UDP server for Binary Thrift {"kind": "receiver", "name": "jaeger", "data_type": "traces", "endpoint": "0.0.0.0:6831"} 2024-12-27T15:37:23.436Z info [email protected]/trace_receiver.go:274 Starting UDP server for Compact Thrift {"kind": "receiver", "name": "jaeger", "data_type": "traces", "endpoint": "0.0.0.0:6832"} 2024-12-27T15:37:23.436Z info [email protected]/trace_receiver.go:398 Starting HTTP server for Jaeger Collector {"kind": "receiver", "name": "jaeger", "data_type": "traces", "endpoint": "0.0.0.0:14268"} 2024-12-27T15:37:23.436Z info [email protected]/trace_receiver.go:423 Starting gRPC server for Jaeger Collector {"kind": "receiver", "name": "jaeger", "data_type": "traces", "endpoint": "0.0.0.0:14250"} 2024-12-27T15:37:23.436Z info [email protected]/service.go:253 Everything is ready. Begin running and processing data. ``` #### config file used ``` receivers: jaeger: protocols: grpc: endpoint: "0.0.0.0:14250" thrift_http: endpoint: "0.0.0.0:14268" thrift_binary: endpoint: "0.0.0.0:6831" thrift_compact: endpoint: "0.0.0.0:6832" exporters: debug: {} service: pipelines: traces: receivers: [jaeger] exporters: [debug] ``` cc @fatsheep9146 --------- Signed-off-by: Saumyacodes-40 <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]>
1 parent 6df5819 commit 2f9c5cd

File tree

3 files changed

+38
-1
lines changed

3 files changed

+38
-1
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
# Use this changelog template to create an entry for release notes.
2+
3+
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
4+
change_type: enhancement
5+
6+
# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
7+
component: jaegerreceiver
8+
9+
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
10+
note: Log the endpoints of different servers started by jaegerreceiver
11+
12+
# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
13+
issues: [36961]
14+
15+
# (Optional) One or more lines of additional information to render under the primary note.
16+
# These lines will be padded with 2 spaces and then inserted directly into the document.
17+
# Use pipe (|) for multiline entries.
18+
subtext: |
19+
This change logs the endpoints of different servers started by jaegerreceiver. It simplifies debugging by ensuring log messages match configuration settings.
20+
21+
# If your change doesn't affect end users or the exported elements of any package,
22+
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
23+
# Optional: The change log or logs in which this entry should be included.
24+
# e.g. '[user]' or '[user, api]'
25+
# Include 'user' if the change is relevant to end users.
26+
# Include 'api' if there is a change to a library API.
27+
# Default: '[user]'
28+
change_logs: [user]

receiver/jaegerreceiver/go.mod

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ require (
2727
go.opentelemetry.io/collector/semconv v0.118.1-0.20250121185328-fbefb22cc2b3
2828
go.uber.org/goleak v1.3.0
2929
go.uber.org/multierr v1.11.0
30+
go.uber.org/zap v1.27.0
3031
google.golang.org/grpc v1.69.4
3132
)
3233

@@ -75,7 +76,6 @@ require (
7576
go.opentelemetry.io/otel/sdk v1.34.0 // indirect
7677
go.opentelemetry.io/otel/sdk/metric v1.34.0 // indirect
7778
go.opentelemetry.io/otel/trace v1.34.0 // indirect
78-
go.uber.org/zap v1.27.0 // indirect
7979
golang.org/x/net v0.34.0 // indirect
8080
golang.org/x/sys v0.29.0 // indirect
8181
golang.org/x/text v0.21.0 // indirect

receiver/jaegerreceiver/trace_receiver.go

+9
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ import (
3030
"go.opentelemetry.io/collector/receiver"
3131
"go.opentelemetry.io/collector/receiver/receiverhelper"
3232
"go.uber.org/multierr"
33+
"go.uber.org/zap"
3334
"google.golang.org/grpc"
3435

3536
jaegertranslator "github.com/open-telemetry/opentelemetry-collector-contrib/pkg/translator/jaeger"
@@ -214,6 +215,8 @@ func (jr *jReceiver) startAgent() error {
214215
return err
215216
}
216217
jr.agentProcessors = append(jr.agentProcessors, processor)
218+
219+
jr.settings.Logger.Info("Starting UDP server for Binary Thrift", zap.String("endpoint", jr.config.ThriftBinaryUDP.Endpoint))
217220
}
218221

219222
if jr.config.ThriftCompactUDP != nil {
@@ -234,6 +237,8 @@ func (jr *jReceiver) startAgent() error {
234237
return err
235238
}
236239
jr.agentProcessors = append(jr.agentProcessors, processor)
240+
241+
jr.settings.Logger.Info("Starting UDP server for Compact Thrift", zap.String("endpoint", jr.config.ThriftCompactUDP.Endpoint))
237242
}
238243

239244
jr.goroutines.Add(len(jr.agentProcessors))
@@ -339,6 +344,8 @@ func (jr *jReceiver) startCollector(ctx context.Context, host component.Host) er
339344
return err
340345
}
341346

347+
jr.settings.Logger.Info("Starting HTTP server for Jaeger Thrift", zap.String("endpoint", jr.config.ThriftHTTP.Endpoint))
348+
342349
jr.goroutines.Add(1)
343350
go func() {
344351
defer jr.goroutines.Done()
@@ -362,6 +369,8 @@ func (jr *jReceiver) startCollector(ctx context.Context, host component.Host) er
362369

363370
api_v2.RegisterCollectorServiceServer(jr.grpc, jr)
364371

372+
jr.settings.Logger.Info("Starting gRPC server for Jaeger Protobuf", zap.String("endpoint", jr.config.GRPC.NetAddr.Endpoint))
373+
365374
jr.goroutines.Add(1)
366375
go func() {
367376
defer jr.goroutines.Done()

0 commit comments

Comments
 (0)