Skip to content

Commit b33549e

Browse files
committed
resolving comments for consistency
1 parent 0ee8386 commit b33549e

File tree

6 files changed

+51
-25
lines changed

6 files changed

+51
-25
lines changed

.github/workflows/sanity-workflow.yml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -72,19 +72,19 @@ jobs:
7272
cd junit-4/ios
7373
mvn compile
7474
mvn test -P sample-local-test -D"browserstack.app"="./LocalSample.ipa"
75-
- name: Run gradle test for junit4 android
75+
- name: Run gradle test for junit4 android
7676
run: |
7777
cd junit-4/android
7878
gradle clean sampleTest
79-
- name: Run gradle sample-local-test for junit4 android
79+
- name: Run gradle sample-local-test for junit4 android
8080
run: |
8181
cd junit-4/android
8282
gradle clean sampleLocalTest -D"browserstack.app"="./LocalSample.apk"
83-
- name: Run gradle test for junit4 ios
83+
- name: Run gradle test for junit4 ios
8484
run: |
8585
cd junit-4/ios
8686
gradle clean sampleTest
87-
- name: Run gradle sample-local-test for junit4 ios
87+
- name: Run gradle sample-local-test for junit4 ios
8888
run: |
8989
cd junit-4/ios
9090
gradle clean sampleLocalTest -D"browserstack.app"="./LocalSample.ipa"
@@ -108,19 +108,19 @@ jobs:
108108
cd junit-5/ios
109109
mvn compile
110110
mvn test -P sample-local-test -D"browserstack.app"="./LocalSample.ipa"
111-
- name: Run gradle test for junit5 android
111+
- name: Run gradle test for junit5 android
112112
run: |
113113
cd junit-5/android
114114
gradle clean sampleTest
115-
- name: Run gradle sample-local-test for junit4 android
115+
- name: Run gradle sample-local-test for junit5 android
116116
run: |
117117
cd junit-5/android
118118
gradle clean sampleLocalTest -D"browserstack.app"="./LocalSample.apk"
119-
- name: Run gradle test for junit4 ios
119+
- name: Run gradle test for junit5 ios
120120
run: |
121121
cd junit-5/ios
122122
gradle clean sampleTest
123-
- name: Run gradle sample-local-test for junit4 ios
123+
- name: Run gradle sample-local-test for junit5 ios
124124
run: |
125125
cd junit-5/ios
126126
gradle clean sampleLocalTest -D"browserstack.app"="./LocalSample.ipa"

README.md

Lines changed: 39 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,13 @@ These code samples are currently based on:
2121
- For Windows, download latest java version from [here](https://java.com/en/download/) and run the installer executable
2222
- For Mac and Linux, run `java -version` to see what java version is pre-installed. If you want a different version download from [here](https://java.com/en/download/)
2323

24-
2. Maven
24+
2. Maven (Only required if using Maven as the build tool)
25+
2526
- If Maven is not downloaded, download it from [here](https://maven.apache.org/download.cgi)
2627
- For installation, follow the instructions [here](https://maven.apache.org/install.html)
2728

28-
3. Gradle
29+
3. Gradle (Only required if using Gradle as the build tool)
30+
2931
- If Gradle is not downloaded, download it from [here](https://gradle.org/releases/)
3032
- For installation, follow the instructions [here](https://gradle.org/install/)
3133

@@ -73,13 +75,25 @@ Getting Started with Appium tests in Junit4 and Junit5 on BrowserStack couldn't
7375
7476
- Junit4
7577
- Update `browserstack.yml` file at root level of [Android Junit4 examples](junit-4/android) or [iOS Junit4 examples](junit-4/ios) with your [BrowserStack Username and Access Key](https://www.browserstack.com/accounts/settings)
76-
- Run `mvn test -P sample-test` to run in maven enviroment.
77-
- Run `gradle clean sampleTest` to run in gradle enviroment.
78+
- **For Maven:** Run the following command to execute tests in the Maven environment:
79+
```sh
80+
mvn test -P sample-test
81+
```
82+
- **For Gradle:** Run the following command to execute tests in the Gradle environment:
83+
```sh
84+
gradle clean sampleTest
85+
```
7886
7987
- Junit5
8088
- Update `browserstack.yml` file at root level of [Android Junit5 examples](junit-5/android) or [iOS Junit5 examples](junit-5/ios) with your [BrowserStack Username and Access Key](https://www.browserstack.com/accounts/settings)
81-
- Run `mvn test -P sample-test`
82-
- Run `gradle clean sampleTest` to run in gradle enviroment.
89+
- **For Maven:** Run the following command to execute tests in the Maven environment:
90+
```sh
91+
mvn test -P sample-test
92+
```
93+
- **For Gradle:** Run the following command to execute tests in the Gradle environment:
94+
```sh
95+
gradle clean sampleTest
96+
```
8397
8498
### **Use Local testing for apps that access resources hosted in development or testing environments :**
8599
@@ -89,17 +103,29 @@ Getting Started with Appium tests in Junit4 and Junit5 on BrowserStack couldn't
89103
```
90104
browserstackLocal: true
91105
```
92-
- Run `mvn test -P sample-local-test` to run in maven enviroment.
93-
- Run `gradle clean sampleLocalTest` to run in gradle enviroment.
106+
- **For Maven:** Run the following command to execute tests in the Maven environment:
107+
```sh
108+
mvn test -P sample-local-test
109+
```
110+
- **For Gradle:** Run the following command to execute tests in the Gradle environment:
111+
```sh
112+
gradle clean sampleLocalTest
113+
```
94114
95-
- Junit5
96-
- Update `browserstack.yml` file at root level of Android Junit5 examples or iOS Junit5 examples with your [BrowserStack Username and Access Key](https://www.browserstack.com/accounts/settings)
97-
- Simply configure the browserstackLocal parameter in the browserstack.yml file accordingly in [Android Junit5 examples](junit-5/android) or [iOS Junit5 examples](junit-5/ios).
115+
- Junit5
116+
- Update `browserstack.yml` file at root level of Android Junit5 examples or iOS Junit5 examples with your [BrowserStack Username and Access Key](https://www.browserstack.com/accounts/settings)
117+
- Simply configure the browserstackLocal parameter in the browserstack.yml file accordingly in [Android Junit5 examples](junit-5/android) or [iOS Junit5 examples](junit-5/ios).
98118
```
99119
browserstackLocal: true
100120
```
101-
- Run `mvn test -P sample-local-test` to run in maven enviroment.
102-
- Run `gradle clean sampleLocalTest` to run in gradle enviroment.
121+
- **For Maven:** Run the following command to execute tests in the Maven environment:
122+
```sh
123+
mvn test -P sample-local-test
124+
```
125+
- **For Gradle:** Run the following command to execute tests in the Gradle environment:
126+
```sh
127+
gradle clean sampleLocalTest
128+
```
103129
104130
**Note**: If you are facing any issues, refer [Getting Help section](#Getting-Help)
105131

junit-5/android/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,4 +48,4 @@ task sampleLocalTest(type: Test) {
4848
include 'com/browserstack/LocalTest*'
4949

5050
jvmArgs "-javaagent:${configurations.testRuntimeClasspath.find { it.name.contains('browserstack-java-sdk') }}"
51-
}
51+
}

junit-5/android/settings.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,4 @@ pluginManagement {
1212
}
1313
}
1414
}
15-
}
15+
}

junit-5/ios/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,4 +48,4 @@ task sampleLocalTest(type: Test) {
4848
include 'com/browserstack/LocalTest*'
4949

5050
jvmArgs "-javaagent:${configurations.testRuntimeClasspath.find { it.name.contains('browserstack-java-sdk') }}"
51-
}
51+
}

junit-5/ios/settings.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,4 @@ pluginManagement {
1212
}
1313
}
1414
}
15-
}
15+
}

0 commit comments

Comments
 (0)