Skip to content
This repository was archived by the owner on Mar 27, 2025. It is now read-only.

Commit e8bcda5

Browse files
committed
fix(BOffcanvas): Aria enhancements -- multiple Offcanvas causes duplicate id
1 parent 3292e35 commit e8bcda5

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

packages/bootstrap-vue-next/src/components/BAccordion/BAccordionItem.vue

+2-2
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
v-model="modelValue"
66
class="accordion-collapse"
77
v-bind="$attrs"
8-
:aria-labelledby="`heading${computedId}`"
8+
:aria-labelledby="`${computedId}-heading`"
99
:tag="tag"
1010
:toggle="toggle"
1111
:horizontal="horizontal"
@@ -14,7 +14,7 @@
1414
v-on="events"
1515
>
1616
<template #header="{visible: toggleVisible, toggle: slotToggle}">
17-
<component :is="headerTag" :id="`heading${computedId}`" class="accordion-header">
17+
<component :is="headerTag" :id="`${computedId}-heading`" class="accordion-header">
1818
<button
1919
class="accordion-button"
2020
:class="{collapsed: !toggleVisible}"

packages/bootstrap-vue-next/src/components/BOffcanvas/BOffcanvas.vue

+2-2
Original file line numberDiff line numberDiff line change
@@ -21,15 +21,15 @@
2121
role="dialog"
2222
:class="computedClasses"
2323
tabindex="-1"
24-
aria-labelledby="offcanvasLabel"
24+
:aria-labelledby="`${computedId}-offcanvas-label`"
2525
data-bs-backdrop="false"
2626
v-bind="$attrs"
2727
@keyup.esc="hide('esc')"
2828
>
2929
<template v-if="lazyShowing">
3030
<div v-if="!noHeaderBoolean" class="offcanvas-header" :class="headerClass">
3131
<slot name="header" v-bind="{visible: modelValueBoolean, placement, hide}">
32-
<h5 id="offcanvasLabel" class="offcanvas-title">
32+
<h5 :id="`${computedId}-offcanvas-label`" class="offcanvas-title">
3333
<slot name="title">
3434
{{ title }}
3535
</slot>

0 commit comments

Comments
 (0)