Skip to content

Commit 1ef1cee

Browse files
Markus Armbrusterebblake
Markus Armbruster
authored andcommitted
Fix up dangling references to qmp-commands.* in comment and doc
Fix up the reference to qmp-commands.hx in qmp.c. Missed in commit 5032a16. Fix up the reference to qmp-commands.txt in docs/xen-save-devices-state.txt. Missed in commit 4d8bb95. Signed-off-by: Markus Armbruster <[email protected]> Message-Id: <[email protected]> Reviewed-by: Eric Blake <[email protected]> Reviewed-by: Marc-André Lureau <[email protected]> Reviewed-by: Michael Roth <[email protected]> Signed-off-by: Eric Blake <[email protected]>
1 parent eb815e2 commit 1ef1cee

File tree

2 files changed

+8
-9
lines changed

2 files changed

+8
-9
lines changed

docs/xen-save-devices-state.txt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,7 @@ These operations are normally used with migration (see migration.txt),
88
however it is also possible to save the state of all devices to file,
99
without saving the RAM or the block devices of the VM.
1010

11-
This operation is called "xen-save-devices-state" (see
12-
qmp-commands.txt)
11+
The save operation is available as QMP command xen-save-devices-state.
1312

1413

1514
The binary format used in the file is the following:

qmp.c

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -147,13 +147,13 @@ VncInfo2List *qmp_query_vnc_servers(Error **errp)
147147

148148
#ifndef CONFIG_SPICE
149149
/*
150-
* qmp-commands.hx ensures that QMP command query-spice exists only
151-
* #ifdef CONFIG_SPICE. Necessary for an accurate query-commands
152-
* result. However, the QAPI schema is blissfully unaware of that,
153-
* and the QAPI code generator happily generates a dead
154-
* qmp_marshal_query_spice() that calls qmp_query_spice(). Provide it
155-
* one, or else linking fails. FIXME Educate the QAPI schema on
156-
* CONFIG_SPICE.
150+
* qmp_unregister_commands_hack() ensures that QMP command query-spice
151+
* exists only #ifdef CONFIG_SPICE. Necessary for an accurate
152+
* query-commands result. However, the QAPI schema is blissfully
153+
* unaware of that, and the QAPI code generator happily generates a
154+
* dead qmp_marshal_query_spice() that calls qmp_query_spice().
155+
* Provide it one, or else linking fails. FIXME Educate the QAPI
156+
* schema on CONFIG_SPICE.
157157
*/
158158
SpiceInfo *qmp_query_spice(Error **errp)
159159
{

0 commit comments

Comments
 (0)