Skip to content

Variable hover not working since v1.23 #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
exh596 opened this issue Jan 9, 2023 · 5 comments
Closed

Variable hover not working since v1.23 #670

exh596 opened this issue Jan 9, 2023 · 5 comments
Labels
question Further information is requested

Comments

@exh596
Copy link

exh596 commented Jan 9, 2023

Hovering over a variable name throws an error in v1.24 and above. v1.23 works properly.

image
image

@skovhus
Copy link
Collaborator

skovhus commented Jan 9, 2023

Thanks for reporting this. Could you provide a failing code example?

@skovhus
Copy link
Collaborator

skovhus commented Jan 11, 2023

@exh596 is this still the case with the latest extension? If so then I would love to get a code example. Thanks. :)

@skovhus skovhus added the question Further information is requested label Jan 11, 2023
@yusufaktepe
Copy link

@exh596 is this still the case with the latest extension? If so then I would love to get a code example. Thanks. :)

Yes, this is still the case (example).

@skovhus
Copy link
Collaborator

skovhus commented Jan 24, 2023

Thanks for the example script. It turns out that for files where the treesitter parser fails, we didn't gracefully handle this in the later version of bash-language-server. I believe the error handling in the latest extension (1.30.0) should now solve this case and hovering should work again.

Let me know if it works for you. Or if you have other suggestions for improving the language server.

@skovhus skovhus closed this as completed Jan 24, 2023
@yusufaktepe
Copy link

Let me know if it works for you.

It seems to be fixed. Thank you for your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants