Skip to content

Curly brackets and dollar symbol invoke comprehensive completion list #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
erusyd opened this issue Dec 23, 2022 · 5 comments · Fixed by #684
Closed

Curly brackets and dollar symbol invoke comprehensive completion list #641

erusyd opened this issue Dec 23, 2022 · 5 comments · Fixed by #684
Labels
bug Something isn't working

Comments

@erusyd
Copy link

erusyd commented Dec 23, 2022

Peek 2022-12-23 16-46
Peek 2022-12-23 17-12

I think this pop up is meaningless.

@erusyd erusyd changed the title Curly brackets invoke comprehensive completion list Curly brackets and dollar symbol invoke comprehensive completion list Dec 23, 2022
@skovhus
Copy link
Collaborator

skovhus commented Dec 26, 2022

Thanks for reporting this, it seems like a bug.

@skovhus skovhus added the bug Something isn't working label Dec 26, 2022
@skovhus
Copy link
Collaborator

skovhus commented Jan 18, 2023

@erusyd a fix has now been released as [email protected] and the latest vscode extension 1.29.0. Let me know if you experience other issues or ideas for future improvements.

@erusyd
Copy link
Author

erusyd commented Jan 30, 2023

I tested it, the dollar($) sign still invokes completion on Emacs.

@skovhus
Copy link
Collaborator

skovhus commented Jan 30, 2023

I tested it, the dollar($) sign still invokes completion on Emacs.

A dollar sign should always invoke completions as we want to complete on variables — but in some cases we return an empty list back to the client.

When the dollar sign lonely or part of a word (. e.g. $M) we return a non empty list of completions. In case it is part of a non word like the examples above we return an empty list of completions.

But please provide an example if something isn’t work as expected.

@erusyd
Copy link
Author

erusyd commented Jan 30, 2023

Solved. It is my Emacs company+yasnippet completion configuration problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants