refactor typings

Author: based-ghost

GhostUI/ClientApp/api/services/auth.service.ts

@@ -16,8 +16,8 @@ class AuthService extends BaseService {
     }
 
     public async login(credentials: ICredentials): Promise<IAuthUser> {
-        const { data } = await this.$http.post('Login', credentials);
-        return data as IAuthUser;
+        const { data } = await this.$http.post<IAuthUser>('Login', credentials);
+        return data;
     }
 
     public async logout(): Promise<any> {

GhostUI/ClientApp/api/services/sample.service.ts

@@ -16,8 +16,12 @@ class SampleService extends BaseService {
     }
 
     public async getWeatherForecastsAsync(startDateIndex: number): Promise<IWeatherForecast[]> {
-        const { data } = await this.$http.get('GetWeatherForecasts', { params: { startDateIndex: startDateIndex } });
-        return data as IWeatherForecast[];
+        const { data } = await this.$http.get<IWeatherForecast[]>(
+          'GetWeatherForecasts',
+          { params: { startDateIndex: startDateIndex } }
+        );
+
+        return data;
     }
 }
 

GhostUI/ClientApp/api/services/signalR.service.ts

@@ -36,7 +36,7 @@ class SignalRService {
 
         setTimeout(() => {
             this._hubConnection.start().catch((error) => {
-                console.error(error.toString());
+                console.error(String(error));
             });
         }, _signalrConfig.CONNECTION_DELAY);
     }

GhostUI/ClientApp/assets/style/scss/base/generic.scss

@@ -24,7 +24,7 @@ code {
     font-size: 0.94em;
     word-break: break-word;
     border-radius: 0.25rem;
-    background-color: rgba(255, 229, 100, 0.2);
+    background-color: rgba(187, 239, 253, 0.325);
     font-family: SFMono-Regular, Menlo, Monaco, Consolas, "Liberation Mono", "Courier New", monospace;
 }
 

GhostUI/ClientApp/components/controls/dropdown/VDropdown.render.tsx

@@ -44,9 +44,7 @@ export default class VDropdown extends Vue {
         </button>
         <div class='dropdown-menu' ref='dropdownMenu' role='menu'>
           <ul class='dropdown-content'>
-            {this.options.map((option: any, index: number) =>
-              this.renderListOption(option, index)
-            )}
+            {this.options.map((option: any, index: number) => this.renderListOption(option, index))}
           </ul>
         </div>
       </div>

GhostUI/ClientApp/components/loaders/Authenticator.vue

@@ -30,7 +30,7 @@ export default class Authenticator extends Vue {
         this.$emit(newValue);
       }, this.emitTimeout);
     } else {
-      this.show = newValue === AuthStatusEnum.Process;
+      this.show = (newValue === AuthStatusEnum.Process);
     }
   }
 }

GhostUI/ClientApp/config/axios.config.ts

@@ -13,7 +13,7 @@ export const configureAxiosInterceptors = (): void => {
     );
 };
 
-export const handleAxiosError = (error: AxiosError): void => {
+const handleAxiosError = (error: AxiosError): void => {
     // Error Message Object
     const message = {
         body: 'Internal Server Error',

GhostUI/ClientApp/store/modules/auth/auth.module.ts

@@ -13,8 +13,8 @@ class Auth extends VuexModule implements IAuthState {
         return (this.token || '').length > 0 && (this.status || '').toLowerCase().includes('success');
     }
 
-    @MutationAction({ mutate: ['token', 'status', 'userName'] })
-    public async LoginUser(credentials: ICredentials): Promise<any> {
+    @MutationAction<IAuthState>({ mutate: ['token', 'status', 'userName'] })
+    public async LoginUser(credentials: ICredentials): Promise<IAuthState> {
         try {
             const authUser = await AuthApi.login(credentials);
             return {

GhostUI/ClientApp/store/modules/auth/types.d.ts

@@ -18,7 +18,7 @@ export interface IAuthUser {
 }
 
 export interface IAuthState {
-  token: string;
-  status: string;
-  userName: string;
+  readonly token?: string;
+  readonly status?: string;
+  readonly userName?: string;
 }

GhostUI/ClientApp/store/modules/form/form.module.ts

@@ -1,11 +1,6 @@
 import store from "../../../store";
 import { IDropdownOption, IFormState } from "./types";
-import {
-  Module,
-  VuexModule,
-  Mutation,
-  getModule
-} from "vuex-module-decorators";
+import { Module, VuexModule, Mutation, getModule } from "vuex-module-decorators";
 
 @Module({ dynamic: true, store, name: "form" })
 class Form extends VuexModule implements IFormState {

GhostUI/ClientApp/store/modules/form/types.d.ts

@@ -1,13 +1,10 @@
 export interface IDropdownOption {
-  value: number;
-  label: string;
+  readonly value: number;
+  readonly label: string;
 }
 
 export interface IFormState {
-  count: number;
-  checkboxValue: boolean;
-  selectedDropdownOption: {
-    value: number;
-    label: string;
-  };
+  readonly count: number;
+  readonly checkboxValue: boolean;
+  readonly selectedDropdownOption: IDropdownOption;
 }

GhostUI/ClientApp/store/modules/weather-forecasts/types.d.ts

@@ -1,12 +1,12 @@
 export interface IWeatherForecast {
-  ID: number;
-  DateFormatted: string;
-  TemperatureC: number;
-  TemperatureF: number;
-  Summary: string;
+  readonly ID: number;
+  readonly DateFormatted: string;
+  readonly TemperatureC: number;
+  readonly TemperatureF: number;
+  readonly Summary: string;
 }
 
 export interface IWeatherForecastsState {
-  startDateIndex?: number;
-  forecasts?: IWeatherForecast[];
+  readonly startDateIndex?: number;
+  readonly forecasts?: IWeatherForecast[];
 }

GhostUI/ClientApp/store/modules/weather-forecasts/weather-forecasts.module.ts

@@ -1,20 +1,15 @@
 import store from "../../../store";
 import { SampleApi } from "../../../api";
 import { IWeatherForecast, IWeatherForecastsState } from "./types";
-import {
-  Module,
-  VuexModule,
-  MutationAction,
-  getModule
-} from "vuex-module-decorators";
+import { Module, VuexModule, MutationAction, getModule } from "vuex-module-decorators";
 
 @Module({ dynamic: true, store, name: "forecasts" })
 class WeatherForecast extends VuexModule implements IWeatherForecastsState {
   public startDateIndex: number = 0;
   public forecasts: IWeatherForecast[] = [];
 
-  @MutationAction({ mutate: ["forecasts", "startDateIndex"] })
-  public async GetWeatherForecasts(index: number | null): Promise<any> {
+  @MutationAction<IWeatherForecastsState>({ mutate: ["forecasts", "startDateIndex"] })
+  public async GetWeatherForecasts(index: number | null): Promise<IWeatherForecastsState> {
     try {
       const forecasts = await SampleApi.getWeatherForecastsAsync(index || 0);
       return {

GhostUI/ClientApp/views/FetchData.vue

@@ -54,14 +54,14 @@ import {
 export default class FetchData extends Vue {
   private loading: boolean = false;
 
-  get currentStartDateIndex(): number {
-    return WeatherForecastModule.startDateIndex;
-  }
-
   get forecasts(): IWeatherForecast[] {
     return WeatherForecastModule.forecasts;
   }
 
+  get currentStartDateIndex(): number {
+    return WeatherForecastModule.startDateIndex;
+  }
+
   private created(): void {
     if (!this.forecasts || this.forecasts.length === 0) {
       this.handleGetWeatherForecasts();

GhostUI/ClientApp/views/Login.vue

@@ -138,10 +138,7 @@ export default class Login extends Vue {
 
   private onAuthFailure(): void {
     this.authStatus = AuthStatusEnum.None;
-    this.$snotify.error(
-      `Could not authenticate: ${this.credentials.userName}`,
-      "Login Error"
-    );
+    this.$snotify.error(`Could not authenticate: ${this.credentials.userName}`, "Login Error");
   }
 }
 </script>

GhostUI/HealthChecks/GCInfo/GCInfoHealthCheck.cs

@@ -16,12 +16,13 @@ public GCInfoHealthCheck(IOptionsMonitor<GCInfoOptions> options)
             _options = options;
         }
 
-        public Task<HealthCheckResult> CheckHealthAsync(HealthCheckContext context, CancellationToken cancellationToken = default(CancellationToken))
+        public Task<HealthCheckResult> CheckHealthAsync(HealthCheckContext context, CancellationToken cancellationToken = default)
         {
             // This example will report degraded status if the application is using more than the configured amount of memory (1gb by default).
             // Additionally we include some GC info in the reported diagnostics.
             var options = _options.Get(context.Registration.Name);
             var allocated = GC.GetTotalMemory(forceFullCollection: false);
+
             var data = new Dictionary<string, object>
             {
                 { "Allocated", allocated },
@@ -32,7 +33,9 @@ public GCInfoHealthCheck(IOptionsMonitor<GCInfoOptions> options)
 
             // Report failure if the allocated memory is >= the threshold.
             // Using context.Registration.FailureStatus means that the application developer can configure how they want failures to appear.
-            var result = allocated >= options.Threshold ? context.Registration.FailureStatus : HealthStatus.Healthy;
+            var result = allocated >= options.Threshold
+                ? context.Registration.FailureStatus
+                : HealthStatus.Healthy;
 
             return Task.FromResult(new HealthCheckResult(
                 result,