Skip to content

fix(metrics): publish metrics even if handler throw #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 2, 2021

Conversation

flochaz
Copy link
Contributor

@flochaz flochaz commented Nov 30, 2021

Description of your changes

Current code does not catch exception when wrapping handler call which prevent metrics to be published if error thrown.

How to verify this change

Added UT.

Related issues, RFCs

Fix #248

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published in downstream module
  • The PR title follows the conventional commit semantics

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@saragerion saragerion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flochaz flochaz merged commit 8ad0a6a into main Dec 2, 2021
@flochaz flochaz deleted the fix/metricsOnError branch December 2, 2021 12:08
@flochaz flochaz mentioned this pull request Dec 6, 2021
10 tasks
@heitorlessa heitorlessa added the bug Something isn't working label Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: metrics not flushing on throw
4 participants