Skip to content

Commit a660142

Browse files
authored
fix: add global hostnames for additional regions (#4675)
* fix: add global hostnames for additional regions * fix: additional test cases for route53 partition endpoints
1 parent 09b57a6 commit a660142

File tree

2 files changed

+31
-0
lines changed

2 files changed

+31
-0
lines changed

lib/region_config_data.json

+12
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,8 @@
3636
"globalEndpoint": true,
3737
"signingRegion": "us-isob-east-1"
3838
},
39+
"us-isof-*/route53": "globalUsIsof",
40+
"eu-isoe-*/route53": "globalEuIsoe",
3941

4042
"*/waf": "globalSSL",
4143

@@ -241,6 +243,16 @@
241243
"globalEndpoint": true,
242244
"signingRegion": "us-gov-west-1"
243245
},
246+
"globalUsIsof": {
247+
"endpoint": "{service}.csp.hci.ic.gov",
248+
"globalEndpoint": true,
249+
"signingRegion": "us-isof-south-1"
250+
},
251+
"globalEuIsoe": {
252+
"endpoint": "{service}.cloud.adc-e.uk",
253+
"globalEndpoint": true,
254+
"signingRegion": "eu-isoe-west-1"
255+
},
244256
"s3signature": {
245257
"endpoint": "{service}.{region}.amazonaws.com",
246258
"signatureVersion": "s3"

test/region_config.spec.js

+19
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,25 @@ describe('region_config.js', function() {
1818
});
1919
});
2020

21+
[AWS.Route53].forEach(function(svcClass) {
22+
[
23+
'us-isof-south-1',
24+
'eu-isoe-west-1',
25+
'us-gov-west-1',
26+
'cn-northwest-1',
27+
'cn-north-1'
28+
].forEach(function(region) {
29+
it('uses a global partition endpoint for ' + svcClass.serviceIdentifier, function() {
30+
var service = new svcClass({
31+
region: region
32+
});
33+
expect(service.endpoint.host).to.contain(service.serviceIdentifier + '.');
34+
expect(service.endpoint.host).not.to.contain(region);
35+
expect(service.isGlobalEndpoint).to.equal(true);
36+
});
37+
});
38+
});
39+
2140
it('always enables SSL for Route53', function() {
2241
var service = new AWS.Route53;
2342
expect(service.config.sslEnabled).to.equal(true);

0 commit comments

Comments
 (0)