Skip to content

Docs: wrong documentation for tracer manual mode #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
flochaz opened this issue Dec 16, 2021 · 3 comments
Closed

Docs: wrong documentation for tracer manual mode #329

flochaz opened this issue Dec 16, 2021 · 3 comments
Assignees
Labels
completed This item is complete and has been merged/shipped documentation Improvements or additions to documentation not-a-bug New and existing bug reports incorrectly submitted as bug tracer This item relates to the Tracer Utility
Milestone

Comments

@flochaz
Copy link
Contributor

flochaz commented Dec 16, 2021

Bug description

Using #326 global examples and especially https://github.com/awslabs/aws-lambda-powertools-typescript/blob/examples/cdk/examples/cdk/lib/example-stack.MyFunction.ts#L43

Subsegment does not seems to be created in xray:

Screenshot 2021-12-16 at 09 44 26

And inline doc is not correct (importing Segment and using Subsegment ... ):

Expected Behavior

To have a subsegment called MySubSegment showing up in xray.

Current Behavior

Just basic segment showing

Possible Solution

Steps to Reproduce

  1. branch example/cdk
  2. deploy example
  3. check xray

Environment

  • Powertools version used: 0.1.0-beta-9
  • Packaging format (Layers, npm): npm
  • AWS Lambda function runtime: NODEJS_14
  • Debugging logs: NA
@flochaz flochaz added the bug Something isn't working label Dec 16, 2021
@dreamorosi dreamorosi changed the title (tracing): short issue description (tracing): Tracer not working in manual mode Dec 16, 2021
@dreamorosi dreamorosi added the tracer This item relates to the Tracer Utility label Dec 16, 2021
@dreamorosi dreamorosi added this to the beta-release milestone Dec 16, 2021
@dreamorosi
Copy link
Contributor

Thanks for raising this, will take a look at it today and let you know!

@dreamorosi
Copy link
Contributor

dreamorosi commented Dec 16, 2021

The examples shown for manual instrumentation in the docs are wrong (my bad - will update them), I've pushed a commit to your PR to provide examples that work & actually create the segments (see screenshots below) and I've also opened a separate issue #334 to expose better APIs as discussed.

image
image

Will be closing this for now.

@github-actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@dreamorosi dreamorosi changed the title (tracing): Tracer not working in manual mode Bug: tracer not working in manual mode Nov 14, 2022
@dreamorosi dreamorosi added completed This item is complete and has been merged/shipped documentation Improvements or additions to documentation not-a-bug New and existing bug reports incorrectly submitted as bug and removed bug Something isn't working labels Nov 14, 2022
@dreamorosi dreamorosi changed the title Bug: tracer not working in manual mode Docs: wrong documentation for tracer manual mode Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed This item is complete and has been merged/shipped documentation Improvements or additions to documentation not-a-bug New and existing bug reports incorrectly submitted as bug tracer This item relates to the Tracer Utility
Projects
None yet
Development

No branches or pull requests

2 participants