Skip to content

Maintenance: remove a dependency to deprecated library @aws-sdk/util-base64-node #2246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks done
yamatatsu opened this issue Mar 18, 2024 · 3 comments · Fixed by #2247
Closed
2 tasks done

Maintenance: remove a dependency to deprecated library @aws-sdk/util-base64-node #2246

yamatatsu opened this issue Mar 18, 2024 · 3 comments · Fixed by #2247
Assignees
Labels
completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) parameters This item relates to the Parameters Utility

Comments

@yamatatsu
Copy link
Contributor

yamatatsu commented Mar 18, 2024

Summary

Let's remove a deprecated dependency. See, https://www.npmjs.com/package/@aws-sdk/util-base64-node.

Why is this needed?

Following warning is shown on installing @aws-lambda-powertools/parameters;
image

Which area does this relate to?

Parameters, Idempotency

Solution

About idempotency, remove the dependency because it is not used.
About parameters, replace it to @smithy/util-base64.

Acknowledgment

Future readers

Please react with 👍 and your use case to help us understand customer demand.

@yamatatsu yamatatsu added triage This item has not been triaged by a maintainer, please wait internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) labels Mar 18, 2024
@dreamorosi
Copy link
Contributor

Thank you for taking the time to open the issue.

This is a duplicate of #1915, which has a long form explanation of why we kept the dependency around rather than upgrading to the newer one.

Since then, we have invested time in writing our own little utility to convert from base 64 encoded data (#2188), so we should move the Parameters utility to use that instead.

I'm more than happy to review and merge a PR that does that as well as removing the dependency from the Idempotency utility, but I'd be inclined to block the current PR that instead upgrades to the @smithy dependency.

Let me know if that works for you or you have any questions.

@dreamorosi dreamorosi added parameters This item relates to the Parameters Utility discussing The issue needs to be discussed, elaborated, or refined and removed triage This item has not been triaged by a maintainer, please wait labels Mar 18, 2024
@dreamorosi dreamorosi linked a pull request Mar 18, 2024 that will close this issue
9 tasks
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added pending-release This item has been merged and will be released soon and removed discussing The issue needs to be discussed, elaborated, or refined labels Mar 26, 2024
Copy link
Contributor

This is now released under v2.0.4 version!

@github-actions github-actions bot added completed This item is complete and has been merged/shipped and removed pending-release This item has been merged and will be released soon labels Apr 10, 2024
@dreamorosi dreamorosi moved this from Coming soon to Shipped in Powertools for AWS Lambda (TypeScript) Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) parameters This item relates to the Parameters Utility
Projects
Development

Successfully merging a pull request may close this issue.

2 participants