Skip to content

Maintenance: add Middy license to repository notice #1248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task done
saragerion opened this issue Jan 16, 2023 · 1 comment · Fixed by #1249
Closed
1 task done

Maintenance: add Middy license to repository notice #1248

saragerion opened this issue Jan 16, 2023 · 1 comment · Fixed by #1249
Assignees
@dreamorosi
Labels
completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)

Comments

@saragerion
Copy link
Contributor

saragerion commented Jan 16, 2023 •
edited
Loading

What were you searching in the docs?

As @dreamorosi correctly described in this PR, we resolved to temporarily importing the middy types

This workaround is not the best solution. It's supposed to be temporary and will be removed and replaced with a better solution with v2, where we will restore the middy core import.

Other than that, we should credit Middy in our license notice.

Is this related to an existing documentation section?

https://github.com/awslabs/aws-lambda-powertools-typescript/blob/main/LICENSE-THIRD-PARTY

How can we improve?

N/A

Got a suggestion in mind?

N/A

Acknowledgment

  • I understand the final update might be different from my proposed suggestion, or refused.
@saragerion saragerion added documentation Improvements or additions to documentation triage This item has not been triaged by a maintainer, please wait labels Jan 16, 2023
@saragerion saragerion changed the title Docs: add Middy licence to repository notice Docs: add Middy license to repository notice Jan 16, 2023
@dreamorosi dreamorosi added internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) and removed documentation Improvements or additions to documentation triage This item has not been triaged by a maintainer, please wait labels Jan 16, 2023
@dreamorosi dreamorosi changed the title Docs: add Middy license to repository notice Maintenance: add Middy license to repository notice Jan 16, 2023
@dreamorosi dreamorosi added the confirmed The scope is clear, ready for implementation label Jan 16, 2023
@dreamorosi dreamorosi self-assigned this Jan 16, 2023
@dreamorosi dreamorosi moved this from Backlog to Working on it in AWS Lambda Powertools for TypeScript Jan 16, 2023
@dreamorosi dreamorosi mentioned this issue Jan 16, 2023
Merged
13 tasks
@dreamorosi dreamorosi linked a pull request Jan 16, 2023 that will close this issue
chore(internal): add @middy/core license to proejct third-party licenses #1249
Merged
13 tasks
@github-project-automation github-project-automation bot moved this from Working on it to Coming soon in AWS Lambda Powertools for TypeScript Jan 16, 2023
@github-actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added the pending-release This item has been merged and will be released soon label Jan 16, 2023
@dreamorosi dreamorosi removed the pending-release This item has been merged and will be released soon label Jan 16, 2023
@dreamorosi dreamorosi moved this from Coming soon to Shipped in AWS Lambda Powertools for TypeScript Jan 16, 2023
@dreamorosi dreamorosi added completed This item is complete and has been merged/shipped and removed confirmed The scope is clear, ready for implementation labels Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dreamorosi dreamorosi

Labels
completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Projects
None yet
Milestone
No milestone
2 participants
@dreamorosi @saragerion