Skip to content

Documentation Improvement: inconsistency Tracer.ts example code - Tracer Website Docs #1142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
niko-achilles opened this issue Nov 5, 2022 · 5 comments · Fixed by #1144
Closed
Assignees
Labels
completed This item is complete and has been merged/shipped documentation Improvements or additions to documentation not-a-bug New and existing bug reports incorrectly submitted as bug tracer This item relates to the Tracer Utility

Comments

@niko-achilles
Copy link
Contributor

Expected Behaviour

consistency of generated Docs for Tracer -> Lambda Handler -> Manual
Links:

with

Tracer.ts code example snippet in IDE editor
Link: https://github.com/awslabs/aws-lambda-powertools-typescript/blob/main/packages/tracer/src/Tracer.ts#L80

Current Behaviour

Using my IDE and reading the documentation on how to use the Tracer i read
that i should additionally import { Segment } from 'aws-xray-sdk-core';
See line: https://github.com/awslabs/aws-lambda-powertools-typescript/blob/main/packages/tracer/src/Tracer.ts#L80

This is inconsistent with the docs generated on the Website:
See Tracer -> Lambda Handler -> Manual

Links:

Code snippet

see expected and current behavior description

Possible Solution

see expected behavior

Steps to Reproduce

import Tracer in IDE and follow the example without switching to online Docs of Powertools.

AWS Lambda Powertools for TypeScript version

latest

AWS Lambda function runtime

16.x

Packaging format used

Lambda Layers

Debugging logs

No response

@niko-achilles niko-achilles added bug Something isn't working triage This item has not been triaged by a maintainer, please wait labels Nov 5, 2022
@dreamorosi dreamorosi added documentation Improvements or additions to documentation and removed bug Something isn't working labels Nov 5, 2022
@dreamorosi dreamorosi changed the title Bug: inconsistency Tracer.ts example code - Tracer Website Docs Documentation Improvement: inconsistency Tracer.ts example code - Tracer Website Docs Nov 5, 2022
@dreamorosi
Copy link
Contributor

Hi, thank you for opening this issue. We'll be checking the documentation and the docstrings to make sure they match and any update will land in the next release.

However this is not an issue that affects runtime behavior so I've removed the bug categorization and marked this as documentation improvement.

@niko-achilles
Copy link
Contributor Author

ok, i saw that you will look at things for maintenance and found the time to write about this issue, so that the website docs and code example with IDE support is the same.

@dreamorosi dreamorosi self-assigned this Nov 7, 2022
@dreamorosi dreamorosi removed the triage This item has not been triaged by a maintainer, please wait label Nov 7, 2022
@dreamorosi dreamorosi linked a pull request Nov 7, 2022 that will close this issue
11 tasks
@dreamorosi
Copy link
Contributor

I have reviewed the examples and opened a PR #1144, if you check the PR and notice any other issue I have missed please leave a comment in the PR.

I'll report back once it's merged.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added the pending-release This item has been merged and will be released soon label Nov 8, 2022
@dreamorosi dreamorosi removed the pending-release This item has been merged and will be released soon label Nov 9, 2022
@dreamorosi
Copy link
Contributor

Improvements to the docs released in v1.4.1.

@dreamorosi dreamorosi added not-a-bug New and existing bug reports incorrectly submitted as bug tracer This item relates to the Tracer Utility labels Nov 13, 2022
@dreamorosi dreamorosi added the completed This item is complete and has been merged/shipped label Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed This item is complete and has been merged/shipped documentation Improvements or additions to documentation not-a-bug New and existing bug reports incorrectly submitted as bug tracer This item relates to the Tracer Utility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants