-
Notifications
You must be signed in to change notification settings - Fork 155
Documentation Improvement: inconsistency Tracer.ts example code - Tracer Website Docs #1142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi, thank you for opening this issue. We'll be checking the documentation and the docstrings to make sure they match and any update will land in the next release. However this is not an issue that affects runtime behavior so I've removed the bug categorization and marked this as documentation improvement. |
ok, i saw that you will look at things for maintenance and found the time to write about this issue, so that the website docs and code example with IDE support is the same. |
I have reviewed the examples and opened a PR #1144, if you check the PR and notice any other issue I have missed please leave a comment in the PR. I'll report back once it's merged. |
|
Improvements to the docs released in |
Expected Behaviour
consistency of generated Docs for
Tracer
->Lambda Handler
->Manual
Links:
with
Tracer.ts
code example snippet in IDE editorLink: https://github.com/awslabs/aws-lambda-powertools-typescript/blob/main/packages/tracer/src/Tracer.ts#L80
Current Behaviour
Using my IDE and reading the documentation on how to use the Tracer i read
that i should additionally
import { Segment } from 'aws-xray-sdk-core';
See line: https://github.com/awslabs/aws-lambda-powertools-typescript/blob/main/packages/tracer/src/Tracer.ts#L80
This is inconsistent with the docs generated on the Website:
See
Tracer
->Lambda Handler
->Manual
Links:
Code snippet
Possible Solution
see expected behavior
Steps to Reproduce
import Tracer in IDE and follow the example without switching to online Docs of Powertools.
AWS Lambda Powertools for TypeScript version
latest
AWS Lambda function runtime
16.x
Packaging format used
Lambda Layers
Debugging logs
No response
The text was updated successfully, but these errors were encountered: