Skip to content

Maintenance: e2e tests failing #1046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dreamorosi opened this issue Aug 10, 2022 · 2 comments · Fixed by #1047
Closed

Maintenance: e2e tests failing #1046

dreamorosi opened this issue Aug 10, 2022 · 2 comments · Fixed by #1047
Assignees
Labels
automation This item relates to automation completed This item is complete and has been merged/shipped
Milestone

Comments

@dreamorosi
Copy link
Contributor

Bug description

E2E tests are failing after the changes related to #826.

There’s a dependency issue in the job section that tests the layers, and as far as I can tell it’s because it’s requiring something from commons but we are installing the dependencies only in [layer-publisher](https://github.com/awslabs/aws-lambda-powertools-typescript/tree/main/layer-publisher).

Expected Behavior

E2E tests passing.

Current Behavior

See here.

Possible Solution

I remember advocating for this usage during review, now I'm wondering if we should use the published version or the local one. If the local one then we'll have to install commons in that job.

Steps to Reproduce

N/A

Environment

  • Powertools version used: main
  • Packaging format (Layers, npm): Layers
  • AWS Lambda function runtime: N/A
  • Debugging logs: N/A

Related issues, RFCs

#826

@dreamorosi dreamorosi added bug Something isn't working triage This item has not been triaged by a maintainer, please wait labels Aug 10, 2022
@dreamorosi dreamorosi added this to the Lambda layer milestone Aug 10, 2022
@dreamorosi dreamorosi linked a pull request Aug 10, 2022 that will close this issue
8 tasks
@github-actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added the pending-release This item has been merged and will be released soon label Aug 10, 2022
@dreamorosi dreamorosi assigned dreamorosi and unassigned flochaz Aug 11, 2022
@dreamorosi dreamorosi removed the triage This item has not been triaged by a maintainer, please wait label Aug 11, 2022
@dreamorosi dreamorosi removed the pending-release This item has been merged and will be released soon label Aug 12, 2022
@dreamorosi
Copy link
Contributor Author

Released as a part of v1.1.0

@dreamorosi dreamorosi changed the title Bug (layers): e2e tests failing Maintenance: e2e tests failing Nov 14, 2022
@dreamorosi dreamorosi added automation This item relates to automation completed This item is complete and has been merged/shipped and removed bug Something isn't working labels Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation completed This item is complete and has been merged/shipped
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants