Skip to content

Commit 284d10d

Browse files
author
Alan Churley
committed
MOving env var out of script, and setting node version explicitly
1 parent 968d00e commit 284d10d

File tree

2 files changed

+12
-2
lines changed

2 files changed

+12
-2
lines changed

.github/workflows/on-pull-request.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,16 @@ on:
55
jobs:
66
on_pr:
77
runs-on: ubuntu-latest
8+
env:
9+
NODE_ENV: dev
810
steps:
911
- uses: actions/checkout@v2
12+
- name: Set up Node
13+
uses: actions/setup-node@v2
14+
with:
15+
node-version: '14'
1016
- name: Install packages
1117
run: |
12-
export NODE_ENV=dev
1318
npm ci
1419
npm run lerna-ci
1520
- name: Run lint

.github/workflows/on-push.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,16 @@ jobs:
66
on_push:
77
runs-on: ubuntu-latest
88
if: ${{ github.event_name != 'pull_request' }}
9+
env:
10+
NODE_ENV: dev
911
steps:
1012
- uses: actions/checkout@v2
13+
- name: Set up Node
14+
uses: actions/setup-node@v2
15+
with:
16+
node-version: '14'
1117
- name: Install packages
1218
run: |
13-
export NODE_ENV=dev
1419
npm ci
1520
npm run lerna-ci
1621
- name: Run lint

0 commit comments

Comments
 (0)