Skip to content

Bug: E2E tests are currently not working #1860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rubenfonseca opened this issue Jan 25, 2023 · 2 comments · Fixed by #1861
Closed

Bug: E2E tests are currently not working #1860

rubenfonseca opened this issue Jan 25, 2023 · 2 comments · Fixed by #1861
Assignees
Labels
bug Something isn't working

Comments

@rubenfonseca
Copy link
Contributor

Expected Behaviour

E2E tests are supposed to pass on every commit on the develop branch.

Current Behaviour

E2E tests are failing for a long time.

This is being caused by having more than one test file for some of the utilities. This causes problems as pytest tries to run the same utility at the same time, causing CDK to clash and erroring out.

Code snippet

`make e2e-test`

Possible Solution

There are two possible solutions:

  • make sure each directory only has one test file:

    • PROS: more parallelism
    • CONS: sharing infrastructure between the same utility becomes harder, possibly leading to dupplication
  • change e2e infrastructure to distribute tests per directory instead of per file

Steps to Reproduce

make e2e-test is currently failing on develop

AWS Lambda Powertools for Python version

latest

AWS Lambda function runtime

3.9

Packaging format used

PyPi

Debugging logs

No response

@rubenfonseca rubenfonseca added bug Something isn't working triage Pending triage from maintainers labels Jan 25, 2023
@rubenfonseca rubenfonseca self-assigned this Jan 25, 2023
@rubenfonseca rubenfonseca removed the triage Pending triage from maintainers label Jan 25, 2023
@rubenfonseca rubenfonseca linked a pull request Jan 27, 2023 that will close this issue
7 tasks
@github-actions
Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added the pending-release Fix or implementation already in dev waiting to be released label Jan 30, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023

This is now released under 2.7.1 version!

@github-actions github-actions bot removed the pending-release Fix or implementation already in dev waiting to be released label Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant