Skip to content

Commit 1fd1383

Browse files
committed
Light refactoring
1 parent f3fb7f4 commit 1fd1383

File tree

1 file changed

+20
-14
lines changed

1 file changed

+20
-14
lines changed

ui/arduino/store.js

Lines changed: 20 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -96,8 +96,20 @@ function store(state, emitter) {
9696
emitter.emit('close-port-dialog')
9797

9898
// Make sure there is a lib folder
99+
log('creating lib folder')
99100
await serial.createFolder('lib')
100101

102+
state.serialPath = path
103+
state.serialNavigation = '/'
104+
emitter.emit('update-files')
105+
106+
emitter.emit('message', 'Connected', 1000)
107+
108+
if (!state.isFilesOpen) {
109+
emitter.emit('show-terminal')
110+
}
111+
emitter.emit('render')
112+
101113
// Bind terminal
102114
let term = state.cache(XTerm, 'terminal').term
103115
if (!state.isTerminalBound) {
@@ -112,16 +124,6 @@ function store(state, emitter) {
112124
term.scrollToBottom()
113125
})
114126
serial.onDisconnect(() => emitter.emit('disconnect'))
115-
116-
state.serialPath = path
117-
state.serialNavigation = '/'
118-
emitter.emit('update-files')
119-
120-
emitter.emit('message', 'Connected', 1000)
121-
if (!state.isFilesOpen) {
122-
emitter.emit('show-terminal')
123-
}
124-
emitter.emit('render')
125127
})
126128

127129
// CODE EXECUTION
@@ -149,9 +151,9 @@ function store(state, emitter) {
149151
emitter.on('new-file', (dev) => {
150152
log('new-file', dev)
151153
state.selectedDevice = dev
152-
let editor = state.cache(AceEditor, 'editor').editor
153154
state.selectedFile = null
154155
state.unsavedChanges = false
156+
let editor = state.cache(AceEditor, 'editor').editor
155157
editor.setValue('')
156158
emitter.emit('close-new-file-dialog')
157159
emitter.emit('render')
@@ -162,7 +164,7 @@ function store(state, emitter) {
162164
let contents = cleanCharacters(editor.getValue())
163165
editor.setValue(contents)
164166
let filename = state.selectedFile || 'undefined'
165-
let deviceName = state.selectedDevice === 'serial' ? 'board' : 'disk'
167+
let deviceName = getDeviceName(state.selectedDevice)
166168

167169
state.blocking = true
168170
emitter.emit('message', `Saving ${filename} on ${deviceName}.`)
@@ -193,7 +195,7 @@ function store(state, emitter) {
193195
})
194196
emitter.on('remove', async () => {
195197
log('remove')
196-
let deviceName = state.selectedDevice === 'serial' ? 'board' : 'disk'
198+
let deviceName = getDeviceName(state.selectedDevice)
197199

198200
state.blocking = true
199201
emitter.emit('render')
@@ -469,7 +471,7 @@ function store(state, emitter) {
469471

470472
let oldFilename = state.selectedFile
471473
state.selectedFile = filename
472-
let deviceName = state.selectedDevice === 'serial' ? 'board' : 'disk'
474+
let deviceName = getDeviceName(state.selectedDevice)
473475

474476
let editor = state.cache(AceEditor, 'editor').editor
475477
let contents = cleanCharacters(editor.getValue())
@@ -622,3 +624,7 @@ function cleanPath(path) {
622624
function cleanCharacters(str) {
623625
return str.replace(/[\u{0080}-\u{FFFF}]/gu,"")
624626
}
627+
628+
function getDeviceName(dev) {
629+
return dev === 'serial' ? 'board' : 'disk'
630+
}

0 commit comments

Comments
 (0)