Skip to content

Commit 4d109fe

Browse files
committed
Remove inappropriate element from paths filters of "Check Packaging" workflow
The `on.*.paths` keys of GitHub workflows can be used to avoid unnecessary or unwanted workflow runs. This is done by defining specific paths containing files relevant to the workflow's purpose. The workflow will only run when the trigger event modifies a file matching the paths. The "Check Packaging" workflow was copied from another project that uses the Task task runner tool. In that project, it is appropriate for the workflow to be triggered on any change to the Task configuration file, and so it was added to the `paths` filter. This project uses npm instead of Task, and does not contain a taskfile, so the presence of that path in the filters is in appropriate and only adds unnecessary complexity to the workflow.
1 parent 2086b35 commit 4d109fe

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

.github/workflows/check-packaging-ncc-typescript-npm.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ on:
1111
- "lerna.json"
1212
- "package.json"
1313
- "package-lock.json"
14-
- "Taskfile.ya?ml"
1514
- "tsconfig.json"
1615
- "**.[jt]sx?"
1716
pull_request:
@@ -20,7 +19,6 @@ on:
2019
- "lerna.json"
2120
- "package.json"
2221
- "package-lock.json"
23-
- "Taskfile.ya?ml"
2422
- "tsconfig.json"
2523
- "**.[jt]sx?"
2624
workflow_dispatch:

0 commit comments

Comments
 (0)