Skip to content

add version as ldflag #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
umbynos opened this issue Oct 10, 2022 · 1 comment
Closed

add version as ldflag #137

umbynos opened this issue Oct 10, 2022 · 1 comment
Assignees
@MatteoPologruto
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement

Comments

@umbynos
Copy link
Contributor

umbynos commented Oct 10, 2022

currently during the release we have to manually set the version in

arduino-language-server/ls/ls.go

Line 359 in 6aec1ed

Version: "0.7.2",
This can be enhanced like we do in the Arduino CLI: https://github.com/arduino/arduino-cli/blob/master/Taskfile.yml#L351
@umbynos umbynos added topic: code Related to content of the project itself topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement labels Oct 10, 2022
@umbynos umbynos assigned cmaglie and MatteoPologruto and unassigned cmaglie Oct 10, 2022
@MatteoPologruto
Copy link
Contributor

Done here: #139

@per1234 per1234 added the conclusion: resolved Issue was resolved label Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MatteoPologruto MatteoPologruto

Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@cmaglie @per1234 @umbynos @MatteoPologruto