Skip to content

[sketchbook] The view shows broken hierarchy when opening the MarlinFirmware/Marlin project #1038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
kittaakos opened this issue Jun 10, 2022 · 3 comments
Closed
3 tasks done
Assignees
Labels
conclusion: invalid Issue/PR not valid topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@kittaakos
Copy link
Contributor

Describe the problem

The view shows some strange sketchbook hierarchy when I have Marlin project opened in IDE2.

Screen Shot 2022-06-10 at 16 44 53

The actual FS content:

% ls -al
total 0
drwxr-xr-x  14 a.kitta  staff  448 Jun 10 16:43 .
drwx------+  5 a.kitta  staff  160 May 27 15:32 ..
drwxr-xr-x  21 a.kitta  staff  672 Jun 10 16:43 Marlin
drwxr-xr-x@  4 a.kitta  staff  128 Jun 10 16:32 MultipleFiles
drwxr-xr-x@  3 a.kitta  staff   96 Jun  9 14:09 libraries
drwxr-xr-x   4 a.kitta  staff  128 Jun  2 14:31 sketch with space
drwxr-xr-x   3 a.kitta  staff   96 Jun 10 13:11 sketch_jun10a
drwxr-xr-x   3 a.kitta  staff   96 Jun  1 14:56 sketch_jun1a
drwxr-xr-x   6 a.kitta  staff  192 Jun 10 09:37 sketch_jun1b
drwxr-xr-x   3 a.kitta  staff   96 Jun  3 15:11 sketch_jun3a
drwxr-xr-x   4 a.kitta  staff  128 Jun 10 14:12 sketch_jun3b
drwxr-xr-x   3 a.kitta  staff   96 May 27 14:31 sketch_may27a
drwxr-xr-x   3 a.kitta  staff   96 May 27 14:31 sketch_may27b
drwxr-xr-x@  3 a.kitta  staff   96 May 27 14:31 sketch_may27c

To reproduce

Expected behavior

I am not sure what to expect but the sketchbook tree looks incorrect. If there is a complex sketch, IDE2 should show the sketch Marlin as any other sketches.

Arduino IDE version

Version: 2.0.0-rc7 Date: 2022-06-09T08:19:19.877Z CLI Version: 0.23.0 [899dc91b] Copyright © 2022 Arduino SA

Operating system

macOS

Operating system version

12.3.1

Additional context

No response

Issue checklist

  • I searched for previous reports in the issue tracker
  • I verified the problem still occurs when using the latest nightly build
  • My report contains all necessary details
@kittaakos kittaakos added the type: imperfection Perceived defect in any part of project label Jun 10, 2022
@per1234
Copy link
Contributor

per1234 commented Jun 10, 2022

IDE2 should show the sketch Marlin as any other sketches.

It does. Right here:

image

The folder you see here is a parent folder which happens to have the same name as the sketch folder (the sketch is in the Marlin subfolder of the repository):

image

So the sketchbook tree looks like this:

Arduino/
├── Marlin/
│   ├── LICENSE
│   ├── Makefile
│   ├── Marlin/
│   │   ├── Configuration.h
│   │   ├── Configuration_adv.h
│   │   ├── Makefile
│   │   ├── Marlin.ino
│   │   ├── Version.h
│   │   ├── lib/
│   │   └── src/
│   ├── README.md
│   ├── buildroot/
│   ├── config/
│   ├── docker/
│   ├── docker-compose.yml
│   ├── docs/
│   ├── get_test_targets.py
│   ├── ini/
│   ├── platformio.ini
│   └── process-palette.json
├── MultipleFiles/
└── [...]

(note the location of the .ino file at Arduino/Marlin/Marlin/Marlin.ino)

@per1234 per1234 added the status: waiting for information More information must be provided before work can proceed label Jun 11, 2022
@kittaakos
Copy link
Contributor Author

Thanks! I close this issue although the indentation or UX could be improved.

Current:

Screen Shot 2022-06-10 at 18 02 40

Paintbrush edited version:

Screen Shot 2022-06-10 at 18 03 12

@per1234
Copy link
Contributor

per1234 commented Jun 11, 2022

the indentation or UX could be improved

Definitely! I also find it difficult to interpret the tree structure of a nested sketchbook. There is already an item in the private backlog about that (5303). I'll publish that issue to GitHub ASAP so we can track it more effectively.

@per1234 per1234 added conclusion: invalid Issue/PR not valid topic: code Related to content of the project itself and removed status: waiting for information More information must be provided before work can proceed labels Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: invalid Issue/PR not valid topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

No branches or pull requests

2 participants