Skip to content

Commit e36f1e8

Browse files
Remove govet as it's included in golangcilint
1 parent 48d9661 commit e36f1e8

File tree

2 files changed

+0
-41
lines changed

2 files changed

+0
-41
lines changed

.github/workflows/check-go-task.yml

-33
Original file line numberDiff line numberDiff line change
@@ -49,39 +49,6 @@ jobs:
4949
5050
echo "result=$RESULT" >> $GITHUB_OUTPUT
5151
52-
check-errors:
53-
name: check-errors (${{ matrix.module.path }})
54-
needs: run-determination
55-
if: needs.run-determination.outputs.result == 'true'
56-
runs-on: ubuntu-latest
57-
58-
strategy:
59-
fail-fast: false
60-
61-
matrix:
62-
module:
63-
- path: ./
64-
65-
steps:
66-
- name: Checkout repository
67-
uses: actions/checkout@v4
68-
69-
- name: Install Go
70-
uses: actions/setup-go@v4
71-
with:
72-
go-version: ${{ env.GO_VERSION }}
73-
74-
- name: Install Task
75-
uses: arduino/setup-task@v1
76-
with:
77-
repo-token: ${{ secrets.GITHUB_TOKEN }}
78-
version: 3.x
79-
80-
- name: Check for errors
81-
env:
82-
GO_MODULE_PATH: ${{ matrix.module.path }}
83-
run: task go:vet
84-
8552
check-outdated:
8653
name: check-outdated (${{ matrix.module.path }})
8754
needs: run-determination

Taskfile.yml

-8
Original file line numberDiff line numberDiff line change
@@ -126,13 +126,6 @@ tasks:
126126
{{.TEST_LDFLAGS}}
127127
go tool covdata textfmt -i=coverage_data -o coverage_integration.txt
128128
129-
# Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/assets/check-go-task/Taskfile.yml
130-
go:vet:
131-
desc: Check for errors in Go code
132-
dir: '{{default "./" .GO_MODULE_PATH}}'
133-
cmds:
134-
- go vet {{default .DEFAULT_GO_PACKAGES .GO_PACKAGES}}
135-
136129
go:easyjson-generate:
137130
desc: Run easyjson code generation
138131
cmds:
@@ -301,7 +294,6 @@ tasks:
301294
check:
302295
desc: Check fmt and lint
303296
cmds:
304-
- task: go:vet
305297
- task: go:lint
306298
- task: protoc:check
307299

0 commit comments

Comments
 (0)