Fixed linter warning

cmaglie · cmaglie · commit 494679a4dcc7 · 2025-03-31T17:55:08.000+02:00
internal/arduino/builder/internal/utils/utils.go:85:25: QF1004: could use strings.ReplaceAll instead (staticcheck)
                rows := strings.Split(strings.Replace(depFile, "\r\n", "\n", -1), "\n")
                                      ^
diff --git a/internal/arduino/builder/internal/utils/utils.go b/internal/arduino/builder/internal/utils/utils.go
@@ -82,7 +82,7 @@ func ObjFileIsUpToDate(sourceFile, objectFile, dependencyFile *paths.Path) (bool
 	}
 
 	checkDepFile := func(depFile string) (bool, error) {
-		rows := strings.Split(strings.Replace(depFile, "\r\n", "\n", -1), "\n")
+		rows := strings.Split(strings.ReplaceAll(depFile, "\r\n", "\n"), "\n")
 		rows = f.Map(rows, removeEndingBackSlash)
 		rows = f.Map(rows, strings.TrimSpace)
 		rows = f.Map(rows, unescapeDep)

Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,7 @@ func ObjFileIsUpToDate(sourceFile, objectFile, dependencyFile *paths.Path) (bool`
`82`	`82`	`}`
`83`	`83`
`84`	`84`	`checkDepFile := func(depFile string) (bool, error) {`
`85`		`- rows := strings.Split(strings.Replace(depFile, "\r\n", "\n", -1), "\n")`
	`85`	`+ rows := strings.Split(strings.ReplaceAll(depFile, "\r\n", "\n"), "\n")`
`86`	`86`	`rows = f.Map(rows, removeEndingBackSlash)`
`87`	`87`	`rows = f.Map(rows, strings.TrimSpace)`
`88`	`88`	`rows = f.Map(rows, unescapeDep)`