Skip to content

Commit 1388000

Browse files
committed
Removed direct access to stdio streams in completion command
1 parent a393900 commit 1388000

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

cli/completion/completion.go

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -48,22 +48,24 @@ func NewCommand() *cobra.Command {
4848
}
4949

5050
func runCompletionCommand(cmd *cobra.Command, args []string) {
51+
stdOut, _, res := feedback.OutputStreams()
5152
logrus.Info("Executing `arduino-cli completion`")
5253
if completionNoDesc && (args[0] == "powershell") {
5354
feedback.Fatal(tr("Error: command description is not supported by %v", args[0]), errorcodes.ErrGeneric)
5455
}
5556
switch args[0] {
5657
case "bash":
57-
cmd.Root().GenBashCompletionV2(os.Stdout, !completionNoDesc)
58+
cmd.Root().GenBashCompletionV2(stdOut, !completionNoDesc)
5859
case "zsh":
5960
if completionNoDesc {
60-
cmd.Root().GenZshCompletionNoDesc(os.Stdout)
61+
cmd.Root().GenZshCompletionNoDesc(stdOut)
6162
} else {
62-
cmd.Root().GenZshCompletion(os.Stdout)
63+
cmd.Root().GenZshCompletion(stdOut)
6364
}
6465
case "fish":
65-
cmd.Root().GenFishCompletion(os.Stdout, !completionNoDesc)
66+
cmd.Root().GenFishCompletion(stdOut, !completionNoDesc)
6667
case "powershell":
67-
cmd.Root().GenPowerShellCompletion(os.Stdout)
68+
cmd.Root().GenPowerShellCompletion(stdOut)
6869
}
70+
feedback.PrintResult(res())
6971
}

0 commit comments

Comments
 (0)