Added menu entry to disable the compatibility. Removed useless typedef and added warning

Author: agdl

boards.txt

@@ -20,4 +20,8 @@ uno2018.build.core=arduino
 uno2018.build.variant=uno2018
 #uno2018.build.extra_flags=-B{runtime.tools.atpack.path}/gcc/dev/{build.mcu}
 
+menu.mode=Registers emulation
+uno2018.menu.mode.on=ATMEGA328
+uno2018.menu.mode.on.build.extra_flags=-DUNO_WIFI_REV2_328MODE
+uno2018.menu.mode.off=None (ATMEGA4809)
 ##############################################################

cores/arduino/Arduino.h

@@ -142,7 +142,9 @@ bool isDoubleBondedActive(uint8_t pin);
 #include "USBCore.h"
 #include "CDC.h"
 #include "MSC.h"
+#ifdef UNO_WIFI_REV2_328MODE
 #include <UNO_compat.h>
+#endif
 #if defined(HAVE_HWSERIAL0) && defined(HAVE_CDCSERIAL)
 #error "Targets with both UART0 and CDC serial not supported"
 #endif

cores/arduino/UNO_compat.h

@@ -16,6 +16,8 @@
 #pragma once
 #include "Arduino.h"
 
+#warning "ATMEGA328 registers emulation is enabled. You may encounter some speed issue. Please consider to disable it in the Tools menu"
+
 /*
   ARDUINO PIN  ATMEGA 328  ATMEGA 4809
   0            PD0         PC5
@@ -60,11 +62,6 @@
 #define SET_OR_CLEAR_DIR_REGISTER(inPosition, port, position) if ((uint8_t)~(1 << inPosition) & (uint8_t)value) { port.DIRSET = (1 << position); } else {port.DIRCLR = (1 << position); }
 
 
-typedef struct pinPort {
-  volatile PORT_t*  port;
-  uint8_t pin;
-};
-
 /** DDR Classes**/
 class DDRBClass {
   public: