Removed destructor from File.cpp and SD.h as it leads to unexpected close/destructed objects #814

Author: Federico Fissore

build/shared/revisions.txt

@@ -19,6 +19,7 @@ ARDUINO 1.5.5 BETA
 * avr: Fixed wrong extended fuses on Arduino Yún when using external programmer
 * avr: Added yun variant with LED_BUILTIN definition
 * avr: Refactored Mega* variants definitions in boards.txt (Kristian Sloth Lauszus)
+* avr: Removed File object destructor. In order to free memory allocated by a File object the safest way is to call its close() method
 
 ARDUINO 1.5.4 BETA 2013.09.10
 

libraries/SD/src/File.cpp

@@ -43,11 +43,6 @@ File::File(void) {
   //Serial.print("Created empty file object");
 }
 
-File::~File(void) {
- close();
-  //  Serial.print("Deleted file object");
-}
-
 // returns a pointer to the file name
 char *File::name(void) {
   return _name;

libraries/SD/src/SD.h

@@ -31,7 +31,6 @@ class File : public Stream {
 public:
   File(SdFile f, const char *name);     // wraps an underlying SdFile
   File(void);      // 'empty' constructor
-  ~File(void);     // destructor
   virtual size_t write(uint8_t);
   virtual size_t write(const uint8_t *buf, size_t size);
   virtual int read();