Skip to content

Commit f858457

Browse files
committed
Revert "Fix regression re report-size-deltas after updating actions/upload-artifact. (#51)"
This reverts commit 92e8561.
1 parent 92e8561 commit f858457

File tree

3 files changed

+27
-33
lines changed

3 files changed

+27
-33
lines changed

.github/workflows/compile-examples.yml

Lines changed: 3 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ on:
1919
repository_dispatch:
2020

2121
jobs:
22-
compile:
22+
build:
2323
name: ${{ matrix.board.fqbn }}
2424
runs-on: ubuntu-latest
2525

@@ -34,47 +34,36 @@ jobs:
3434
- fqbn: arduino:samd:arduino_zero_edbg
3535
platforms: |
3636
- name: arduino:samd
37-
artifact-name-suffix: arduino-samd-arduino_zero_edbg
3837
- fqbn: arduino:samd:mkr1000
3938
platforms: |
4039
- name: arduino:samd
41-
artifact-name-suffix: arduino-samd-mkr1000
4240
- fqbn: arduino:samd:mkrzero
4341
platforms: |
4442
- name: arduino:samd
45-
artifact-name-suffix: arduino-samd-mkrzero
4643
- fqbn: arduino:samd:mkrwifi1010
4744
platforms: |
4845
- name: arduino:samd
49-
artifact-name-suffix: arduino-samd-mkrwifi1010
5046
- fqbn: arduino:samd:mkrfox1200
5147
platforms: |
5248
- name: arduino:samd
53-
artifact-name-suffix: arduino-samd-mkrfox1200
5449
- fqbn: arduino:samd:mkrwan1300
5550
platforms: |
5651
- name: arduino:samd
57-
artifact-name-suffix: arduino-samd-mkrwan1300
5852
- fqbn: arduino:samd:mkrwan1310
5953
platforms: |
6054
- name: arduino:samd
61-
artifact-name-suffix: arduino-samd-mkrwan1310
6255
- fqbn: arduino:samd:mkrgsm1400
6356
platforms: |
6457
- name: arduino:samd
65-
artifact-name-suffix: arduino-samd-mkrgsm1400
6658
- fqbn: arduino:samd:mkrnb1500
6759
platforms: |
6860
- name: arduino:samd
69-
artifact-name-suffix: arduino-samd-mkrnb1500
7061
- fqbn: arduino:samd:mkrvidor4000
7162
platforms: |
7263
- name: arduino:samd
73-
artifact-name-suffix: arduino-samd-mkrvidor4000
7464
- fqbn: arduino:samd:nano_33_iot
7565
platforms: |
7666
- name: arduino:samd
77-
artifact-name-suffix: arduino-samd-nano_33_iot
7867
7968
steps:
8069
- name: Checkout repository
@@ -95,27 +84,9 @@ jobs:
9584
enable-deltas-report: true
9685
sketches-report-path: ${{ env.SKETCHES_REPORTS_PATH }}
9786

98-
- name: Upload sketches report to workflow artifact
87+
- name: Save sketches report as workflow artifact
9988
uses: actions/upload-artifact@v4
10089
with:
10190
if-no-files-found: error
10291
path: ${{ env.SKETCHES_REPORTS_PATH }}
103-
name: sketches-report-${{ matrix.board.artifact-name-suffix }}
104-
105-
# When using a matrix to compile for multiple boards, it's necessary to use a separate job for the deltas report
106-
report:
107-
needs: compile # Wait for the compile job to finish to get the data for the report
108-
if: github.event_name == 'pull_request' # Only run the job when the workflow is triggered by a pull request
109-
runs-on: ubuntu-latest
110-
111-
steps:
112-
# This step is needed to get the size data produced by the compile jobs
113-
- name: Download sketches reports artifacts
114-
uses: actions/download-artifact@v4
115-
with:
116-
# All workflow artifacts will be downloaded to this location.
117-
path: ${{ env.SKETCHES_REPORTS_PATH }}
118-
119-
- uses: arduino/report-size-deltas@v1
120-
with:
121-
sketches-reports-source: ${{ env.SKETCHES_REPORTS_PATH }}
92+
name: ${{ env.SKETCHES_REPORTS_PATH }}
Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
name: Report Size Deltas
2+
3+
# See: https://docs.github.com/en/free-pro-team@latest/actions/reference/events-that-trigger-workflows
4+
on:
5+
push:
6+
paths:
7+
- ".github/workflows/report-size-deltas.yml"
8+
schedule:
9+
# Run at the minimum interval allowed by GitHub Actions.
10+
# Note: GitHub Actions periodically has outages which result in workflow failures.
11+
# In this event, the workflows will start passing again once the service recovers.
12+
- cron: "*/5 * * * *"
13+
workflow_dispatch:
14+
repository_dispatch:
15+
16+
jobs:
17+
report:
18+
runs-on: ubuntu-latest
19+
steps:
20+
- name: Comment size deltas reports to PRs
21+
uses: arduino/report-size-deltas@v1
22+
with:
23+
# The name of the workflow artifact created by the sketch compilation workflow
24+
sketches-reports-source: sketches-reports

.gitignore

Lines changed: 0 additions & 1 deletion
This file was deleted.

0 commit comments

Comments
 (0)