diff --git a/.github/workflows/compile-examples.yml b/.github/workflows/compile-examples.yml index 7aab170..6d996e2 100644 --- a/.github/workflows/compile-examples.yml +++ b/.github/workflows/compile-examples.yml @@ -12,8 +12,8 @@ jobs: "arduino:samd:mkr1000", "arduino:samd:mkrwifi1010", "arduino:samd:nano_33_iot", - "arduino:megaavr:uno2018", - '"esp8266:esp8266:huzzah" "https://arduino.esp8266.com/stable/package_esp8266com_index.json"' + "arduino:megaavr:uno2018" +# '"esp8266:esp8266:huzzah" "https://arduino.esp8266.com/stable/package_esp8266com_index.json"' ] steps: diff --git a/src/MqttClient.cpp b/src/MqttClient.cpp index 8e2684e..97f07a5 100644 --- a/src/MqttClient.cpp +++ b/src/MqttClient.cpp @@ -623,7 +623,11 @@ void MqttClient::poll() } } +#ifndef ARDUINO_ARCH_ESP8266 int MqttClient::connect(IPAddress ip, uint16_t port) +#else +int MqttClient::connect(const IPAddress& ip, uint16_t port) +#endif { return connect(ip, NULL, port); } diff --git a/src/MqttClient.h b/src/MqttClient.h index e0e9d63..b46f622 100644 --- a/src/MqttClient.h +++ b/src/MqttClient.h @@ -65,10 +65,11 @@ class MqttClient : public Client { void poll(); // from Client - virtual int connect(IPAddress ip, uint16_t port = 1883); - virtual int connect(const char *host, uint16_t port = 1883); -#ifdef ESP8266 - virtual int connect(const IPAddress& ip, uint16_t port) { return 0; }; /* ESP8266 core defines this pure virtual in Client.h */ + virtual int connect(const char *host, uint16_t port); +#ifndef ARDUINO_ARCH_ESP8266 + virtual int connect(IPAddress ip, uint16_t port); +#else + virtual int connect(const IPAddress& ip, uint16_t port); /* ESP8266 core 2.5.0 defines this pure virtual in Client.h */ #endif virtual size_t write(uint8_t); virtual size_t write(const uint8_t *buf, size_t size);