Skip to content

setAdvertisedService() conflicts with setManufactureData() #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
WB3Tech opened this issue Aug 11, 2020 · 3 comments
Closed

setAdvertisedService() conflicts with setManufactureData() #103

WB3Tech opened this issue Aug 11, 2020 · 3 comments
Labels
type: imperfection Perceived defect in any part of project

Comments

@WB3Tech
Copy link

WB3Tech commented Aug 11, 2020

Using v.1.1.3, If you set an advertised service, you cannot see any set manufacture data in the advertisement.
@polldo
Copy link
Contributor

polldo commented Aug 11, 2020

Hi @WB3Tech ,
you are right, at the moment an advertised service shadows the manufacturer data.
I'm already thinking about a possible fix to make scan response and advertising data more flexible. I will let you know.

@polldo polldo added the type: imperfection Perceived defect in any part of project label Aug 11, 2020
@WB3Tech
Copy link
Author

WB3Tech commented Aug 11, 2020

@polldo, sounds like you're aware, thanks you!

@polldo
Copy link
Contributor

polldo commented Nov 2, 2020

Fixed here #117
Examples here #134

@polldo polldo closed this as completed Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@polldo @WB3Tech