From ca8813de0851ca5108e9f9e374af05429a777db6 Mon Sep 17 00:00:00 2001 From: Capelinha Date: Wed, 23 Sep 2020 11:57:20 -0300 Subject: [PATCH] fix(analytics): Fix custom data layer function Change arrow function to a normal function to use the arguments object as described in the gtag documentation. That way, analytics sends data back to Google again. Fixes #2505 --- src/analytics/analytics.ts | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/analytics/analytics.ts b/src/analytics/analytics.ts index 291d93656..f91fef573 100644 --- a/src/analytics/analytics.ts +++ b/src/analytics/analytics.ts @@ -65,10 +65,11 @@ export class AngularFireAnalytics { if (!analyticsInitialized) { if (isPlatformBrowser(platformId)) { - gtag = (window[GTAG_FUNCTION_NAME] as any) || ((...args: any[]) => { - (window[DATA_LAYER_NAME] as any).push(args); - }); window[DATA_LAYER_NAME] = window[DATA_LAYER_NAME] || []; + // tslint:disable-next-line: only-arrow-functions + gtag = (window[GTAG_FUNCTION_NAME] as any) || (function(..._args: any[]) { + (window[DATA_LAYER_NAME] as any).push(arguments); + }); analyticsInitialized = zone.runOutsideAngular(() => new Promise(resolve => { window[GTAG_FUNCTION_NAME] = (...args: any[]) => {