-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Won't build with Angular 10 #2526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I tried downgrading to 10.0.0 and I got the same behavior. |
You may want to check this link . It seems to me like support is only offered up to 8, but I could be wrong. |
@Mihai-MCW according to their changelog, 6.0.2 should work on angular 10 https://github.com/angular/angularfire/blob/master/CHANGELOG.md |
+1 |
I made a PR for this #2527 |
@yasinkocak thank you! |
I have the same problem. Can I just copy paste this here firestore.module.d.ts:7:74 - error TS2314: Generic type 'ModuleWithProviders' requires 1 type argument(s). because this is how I googled for the issue and didn't get any results |
Hello angularFire team. I literally spend a ton of money in your app for my clients. At least answer us. It’s a shame that core features are broken. |
set enableIvy to true in tsconfig and tsconfig.app |
@kaptain-ti I had to turn that off because I was using a custom decorator which is not supported by Ivy yet. If that issue is fixed in angular 10 then I will be able to turn ivy back on |
Fix is already merged to master, but not released. Can you release new version? Due this issue I cannot update my library to Angular 10... |
Wow, over 1 month for a type fix |
@vtregner you can install the canary version |
I have the same problem, any update? |
@hlpupo like @shadow1349 suggested, use the canary version. |
Is there an estimated date for releasing 6.0.3?
|
The fix for this was merged over 2 months ago, what's the hold up on releasing? I would rather not have production code relying on a canary version. |
@davideast @jeffbcross can we in any way help speed up the process in general? I would really like to help blockers like these go into production code sooner. Angular 11 is around the corner and we still cannot build all stable libraries with 10 |
It seems the project is dead. Unbelievable ignorance. |
With the fix for #2505 getting into the latest Canary, it looks like (based on #2505 (comment)) that a |
I found another place where |
When I try to build or run my project it won't do either. It says that
ModuleWithProviders<T>
requires 1 type argument (screenshot attached below).Version info
Angular: 10.0.1
Firebase: 7.15.1
AngularFire: 6.0.2
Other (e.g. Ionic/Cordova, Node, browser, operating system):
How to reproduce these conditions
Create an Angular 10 project (with @angular/core version 10.0.1). Add @angular/fire libary. Try to build.
Expected behavior
I should be able to build and run the project.
Actual behavior
The text was updated successfully, but these errors were encountered: