Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Commit 7650afc

Browse files
committed
chore(ci): avoid unnecessarily running grunt prepareDeploy in deploy-docs CI job
Previously, the `grunt prepareDeploy` command was run in both the `prepare-deployment` and `deploy-docs` CI jobs. The reason was that not all files affected by `grunt prepareDeploy` were persisted to the workspace across jobs. More specifically, the command would affect files in the `deploy/` and `scripts/docs.angularjs.org-firebase/` directories and also create a `firebase.json` file at the root directory, but only the `deploy/` directory was [persisted to the workspace][1]. This commit avoids unnecessarily running the `grunt prepareDeploy` command in the `deploy-docs` CI job by ensuring that all affected files will be persisted to the workspace in the `prepare-deployment` CI job, which always runs before `deploy-docs`. [1]: https://github.com/angular/angular.js/blob/295213df953766625462/.circleci/config.yml#L265
1 parent 670656d commit 7650afc

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

.circleci/config.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -342,7 +342,7 @@ jobs:
342342
- persist_to_workspace:
343343
root: *workspace_location
344344
paths:
345-
- ./ng/deploy
345+
- ./ng
346346

347347
# The `deploy-code` job should only run when all of these conditions are true for the build:
348348
# - It is for the `angular/angular.js` repository (not a fork).
@@ -383,7 +383,6 @@ jobs:
383383
- custom_attach_workspace
384384
- init_environment
385385
- skip_unless_stable_branch
386-
- run: yarn grunt prepareDeploy
387386
# Install dependencies for Firebase functions to prevent parsing errors during deployment
388387
# See https://github.com/angular/angular.js/pull/16453
389388
- run: yarn -cwd ~/ng/scripts/docs.angularjs.org-firebase/functions

0 commit comments

Comments
 (0)