Skip to content
This repository was archived by the owner on Oct 2, 2019. It is now read-only.

Collect scope methods such as $scope.up() and $scope.down() into 1 object #9

Closed
ProLoser opened this issue Nov 18, 2013 · 3 comments
Closed

Comments

@ProLoser
Copy link
Member

To prevent cluttering the $scope and accidentally conflicting with user-specified $scope data, I recommend we namespace all the scope methods and values.

For instance, instead of doing $scope.up() we should probably use a $select namespace and do $scope.$select.up(), and so forth along this pattern. This $select object can also then be used to hold the state of the widget.

@dimirc
Copy link
Contributor

dimirc commented Nov 18, 2013

Yes, better. Also I was thinking of losing dependency to ui-utils/ui-keypress and we can simplify template and just do the bindings to these methods at the directive's link fn.

@ProLoser
Copy link
Member Author

Depends on what version you're aiming to support, but I've got no problem with that.

@dimirc
Copy link
Contributor

dimirc commented Dec 18, 2013

Removed dependency to ui-utils/ui-keypress. Changes at 63889f6

@dimirc dimirc closed this as completed Dec 18, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants