Skip to content

Adapter assignment changed #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mrova opened this issue Jul 4, 2016 · 1 comment
Closed

Adapter assignment changed #110

mrova opened this issue Jul 4, 2016 · 1 comment

Comments

@mrova
Copy link

mrova commented Jul 4, 2016

After update to version 1.5.1 all adapter assignments are no longer working for me.

<div ui-scroll-viewport="ui-scroll-viewport" class="coach_notes-msgs aacomment-wrap">
  <div class="coach_notes-msgs-inner">
    <div ui-scroll="item in MyDatasource" padding="0.5" buffer-size="25" start-index="1" adapter="vm.adapter" class="conversation_msg"></div>
  </div>
</div>

So in controller I was accessing it through this.adapter since controller was assigned to vm variable.
Now it's available through $scope.$parent.vm.adapter.

Is that expected behavior?

Is this commit causing it?
8c714d5#diff-acd620d807e19ec97ee631f9cb480854

@mfeingold
Copy link
Contributor

the original intention for the adapter access was to look it up starting from the scope associated with the viewport - this is how all other attributes work. As I was working on implementation of the adapter on controller syntax I discovered that for adapter only the lookup point is the scope associated with the scroller itself. So yes, I considered it to be a bug and fixed it to implement the expected behavior. I think in your situation it would be best to use the adapter on controller syntax

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants