Skip to content

Resolves overwriting broken #1402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aikoven opened this issue Sep 25, 2014 · 7 comments
Closed

Resolves overwriting broken #1402

aikoven opened this issue Sep 25, 2014 · 7 comments

Comments

@aikoven
Copy link

aikoven commented Sep 25, 2014

After update to 0.2.11 resolved values don't get overwritten in child states when transitioning from another state. The resolved value of parent is injected to child state controller instead.

http://plnkr.co/edit/vUNKRrvASevjy4XnwHdE?p=preview

@thorning
Copy link

wow, went here to report the same, but seems you were 7 mins faster :)

@christopherthielen
Copy link
Contributor

Thanks for the plunk. This is a dupe of #1353 and is already fixed in master.

@thorning
Copy link

@christopherthielen I have checked out master, and still see the same error. I have forked the above plucker, http://plnkr.co/edit/83oqJ7YD6wut8uIK54sT?p=preview

@nateabele
Copy link
Contributor

@thorning Your plunk links to 0.2.11.

@thorning
Copy link

@nateabele Are you sure, I have not created a plucker before, so it is quite possible I forked it up :)

When I go to the plucker while not logged in it links to "https://rawgit.com/angular-ui/ui-router/master/release/angular-ui-router.js"

Changing "master" in that url to 0.2.10 and it works as expected. 0.2.11 and master fails

@thorning
Copy link

@nateabele I see my error, the release folder is not updated yet, sorry

@nateabele
Copy link
Contributor

@thorning Yeah, sorry for the confusion. The release folder is only updated when an actual release happens. To test what's in master, you need to follow the readme instructions for building it locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants