Skip to content

Commit f60e9bb

Browse files
committed
Fix MDNS Service Discovery:
- Underscore before names per espressif/arduino-esp32#962 - Only one service per port The combination of both changes is needed to make the service discoverable in OpenHAB The removal of the published http service is maybe something you don't want, but as long as it doesn't serve web pages it is maybe OK?
1 parent 9ddb606 commit f60e9bb

File tree

1 file changed

+5
-11
lines changed

1 file changed

+5
-11
lines changed

examples/ONE/ONE.ino

+5-11
Original file line numberDiff line numberDiff line change
@@ -1091,17 +1091,11 @@ static void webServerInit(void) {
10911091
// Make it possible to query this device from Prometheus/OpenMetrics.
10921092
webServer.on("/metrics", HTTP_GET, webServerMetricsGet);
10931093
webServer.begin();
1094-
MDNS.addService("http", "tcp", 80);
1095-
MDNS.addServiceTxt("http", "_tcp", "model", mdnsModelName);
1096-
MDNS.addServiceTxt("http", "_tcp", "serialno", getDevId());
1097-
MDNS.addServiceTxt("http", "_tcp", "fw_ver", ag.getVersion());
1098-
MDNS.addServiceTxt("http", "_tcp", "vendor", "AirGradient");
1099-
MDNS.addService("http", "tcp", 80);
1100-
MDNS.addService("_airgradient", "tcp", 80);
1101-
MDNS.addServiceTxt("airgradient", "_tcp", "model", mdnsModelName);
1102-
MDNS.addServiceTxt("airgradient", "_tcp", "serialno", getDevId());
1103-
MDNS.addServiceTxt("airgradient", "_tcp", "fw_ver", ag.getVersion());
1104-
MDNS.addServiceTxt("airgradient", "_tcp", "vendor", "AirGradient");
1094+
MDNS.addService("_airgradient", "_tcp", 80);
1095+
MDNS.addServiceTxt("_airgradient", "_tcp", "model", mdnsModelName);
1096+
MDNS.addServiceTxt("_airgradient", "_tcp", "serialno", getDevId());
1097+
MDNS.addServiceTxt("_airgradient", "_tcp", "fw_ver", ag.getVersion());
1098+
MDNS.addServiceTxt("_airgradient", "_tcp", "vendor", "AirGradient");
11051099

11061100
if (xTaskCreate(webServerHandler, "webserver", 1024 * 4, NULL, 5, NULL) !=
11071101
pdTRUE) {

0 commit comments

Comments
 (0)