Skip to content

[bug] TeaserV1 has a redundant $-sign in the action-link #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
leorotzler opened this issue Nov 19, 2021 · 1 comment · May be fixed by #9
Open

[bug] TeaserV1 has a redundant $-sign in the action-link #6

leorotzler opened this issue Nov 19, 2021 · 1 comment · May be fixed by #9
Labels
bug Something isn't working

Comments

@leorotzler
Copy link

Describe the bug
There's a redundant dollar sign on line 46 next to the action title in the TeaserV1:

aem-react-core-wcm-components-base/src/authoring/teaser/v1/TeaserV1.tsx

Line 46 in 29bbc10

return <RoutedLink key={"link-" + index} isRouted={props.routed} className={props.baseCssClass + '__action-link'} to={action.URL}>${action.title}</RoutedLink>

Package version
1.1.6

*Screenshots
Screenshot 2021-11-19 at 15 47 35
*
@leorotzler leorotzler added the bug Something isn't working label Nov 19, 2021
@nhirrle
Copy link

nhirrle commented Nov 29, 2021

Reproducable as well with react core components examples:
http://localhost:4502/content/aem-react-core-spacomponents-example/library/teaser.html?wcmmode=disabled
grafik

sanoodles pushed a commit to valtech-ch/aem-react-core-wcm-components-base that referenced this issue Feb 20, 2022
@samuelgomezvaltech
Fix dollar sign in TeaserV1 action title
d6f08e3 
Fixes adobe#6
@sanoodles sanoodles mentioned this issue Feb 20, 2022
Closed
10 tasks
@samuelgomezvaltech samuelgomezvaltech linked a pull request Feb 21, 2022 that will close this issue
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@leorotzler @nhirrle