Skip to content

Commit e560ac5

Browse files
committed
cleaning errors
1 parent 5312e29 commit e560ac5

File tree

8 files changed

+15
-11
lines changed

8 files changed

+15
-11
lines changed

examples/java/src/test/java/dev/selenium/design_strategies/ActionBot.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
import org.openqa.selenium.By;
2+
import org.openqa.selenium.WebDriver;
3+
import org.openqa.selenium.WebElement;
4+
15
public class ActionBot {
26
private final WebDriver driver;
37

examples/java/src/test/java/dev/selenium/design_strategies/EditIssue.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ public void setOperatingSystem(String operatingSystem) {
3939

4040
public void setSeleniumVersion(String seleniumVersion) {
4141
WebElement field = driver.findElement(By.id("issue_form_selenium-version"));
42-
clearAndType(field, logOutput);
42+
clearAndType(field, seleniumVersion);
4343
}
4444

4545
public void setBrowserVersion(String browserVersion) {

examples/java/src/test/java/dev/selenium/design_strategies/EditIssueBetter.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
import static junit.framework.Assert.assertTrue;
99

10-
public class EditIssueBetter extends LoadableComponent<EditIssue> {
10+
public class EditIssueBetter extends EditIssue {
1111

1212
private final WebDriver driver;
1313

@@ -55,7 +55,7 @@ public void setOperatingSystem(String operatingSystem) {
5555

5656
public void setSeleniumVersion(String seleniumVersion) {
5757
WebElement field = driver.findElement(By.id("issue_form_selenium-version"));
58-
clearAndType(field, logOutput);
58+
clearAndType(field, seleniumVersion);
5959
}
6060

6161
public void setBrowserVersion(String browserVersion) {
@@ -73,10 +73,10 @@ public void setUsingGrid(String usingGrid) {
7373
clearAndType(field, usingGrid);
7474
}
7575

76-
public IssueList submit() {
77-
driver.findElement(By.cssSelector("button[type='submit']")).click();
78-
return new IssueList(driver);
79-
}
76+
// public IssueList submit() {
77+
// driver.findElement(By.cssSelector("button[type='submit']")).click();
78+
// return new IssueList(driver);
79+
// }
8080

8181
private void clearAndType(WebElement field, String text) {
8282
field.clear();

examples/java/src/test/java/dev/selenium/design_strategies/LoadableComponent.java

Whitespace-only changes.

website_and_docs/content/documentation/test_practices/design_strategies.en.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -278,7 +278,7 @@ for your app, it's easy to change them. As an example:
278278
{{< badge-code >}}
279279
{{< /tab >}}
280280
{{< tab header="Java" >}}
281-
{{< gh-codeblock path="/examples/java/src/test/java/dev/selenium/design_strategies/ActionBot.java#L1-L26" >}}
281+
{{< gh-codeblock path="/examples/java/src/test/java/dev/selenium/design_strategies/ActionBot.java#L5-L30" >}}
282282
{{< /tab >}}
283283
{{< tab header="CSharp" >}}
284284
{{< badge-code >}}

website_and_docs/content/documentation/test_practices/design_strategies.ja.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -271,7 +271,7 @@ PageObjectsは、テストでの重複を減らすための便利な方法です
271271
{{< badge-code >}}
272272
{{< /tab >}}
273273
{{< tab header="Java" >}}
274-
{{< gh-codeblock path="/examples/java/src/test/java/dev/selenium/design_strategies/ActionBot.java#L1-L26" >}}
274+
{{< gh-codeblock path="/examples/java/src/test/java/dev/selenium/design_strategies/ActionBot.java#L5-L30" >}}
275275
{{< /tab >}}
276276
{{< tab header="CSharp" >}}
277277
{{< badge-code >}}

website_and_docs/content/documentation/test_practices/design_strategies.pt-br.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -278,7 +278,7 @@ A "bot" is an action-oriented abstraction over the raw Selenium APIs. This means
278278
{{< badge-code >}}
279279
{{< /tab >}}
280280
{{< tab header="Java" >}}
281-
{{< gh-codeblock path="/examples/java/src/test/java/dev/selenium/design_strategies/ActionBot.java#L1-L26" >}}
281+
{{< gh-codeblock path="/examples/java/src/test/java/dev/selenium/design_strategies/ActionBot.java#L5-L30" >}}
282282
{{< /tab >}}
283283
{{< tab header="CSharp" >}}
284284
{{< badge-code >}}

website_and_docs/content/documentation/test_practices/design_strategies.zh-cn.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -292,7 +292,7 @@ for your app, it's easy to change them. As an example:
292292
{{< badge-code >}}
293293
{{< /tab >}}
294294
{{< tab header="Java" >}}
295-
{{< gh-codeblock path="/examples/java/src/test/java/dev/selenium/design_strategies/ActionBot.java#L1-L26" >}}
295+
{{< gh-codeblock path="/examples/java/src/test/java/dev/selenium/design_strategies/ActionBot.java#L5-L30" >}}
296296
{{< /tab >}}
297297
{{< tab header="CSharp" >}}
298298
{{< badge-code >}}

0 commit comments

Comments
 (0)