Skip to content

CoreSVG is a private framework #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lapfelix opened this issue Dec 1, 2019 · 1 comment · Fixed by #14
Closed

CoreSVG is a private framework #13

lapfelix opened this issue Dec 1, 2019 · 1 comment · Fixed by #14

Comments

@lapfelix
Copy link

lapfelix commented Dec 1, 2019

The switch from SVGKit to CoreSVG seems to be a little dangerous.

Specifically, all of these functions and method declarations are private and since the framework is private, Apple could change their method/function signature in an upcoming iOS/macOS update without any warning. It could also lead to apps being refused from the App Store since using private APIs isn't allowed.

@dreampiggy
Copy link
Collaborator

dreampiggy commented Dec 1, 2019

Until we have another choice. Actually.

In next release, I'll encrypt all the private API call without the stringify symbol, which can avoid potential issue. I'll do this in hours.

For exist SVGKit integration, you can always using SDWebImageSVGKitPlugin. It's here and does not disappear.

The reason is simple:

SVGKit is not a Stable Framework and Maintainer is not able to drive that forward development. So, we as a downstream dependency, can not rely on that framework. That's the question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants