Skip to content

NaNs in inflation lecture #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jstac opened this issue Nov 20, 2023 · 2 comments · Fixed by #324
Closed

NaNs in inflation lecture #323

jstac opened this issue Nov 20, 2023 · 2 comments · Fixed by #324

Comments

@jstac
Copy link
Contributor

jstac commented Nov 20, 2023

Lot's of NaNs in the table https://intro.quantecon.org/inflation_history.html#germany

@HumphreyYang , would you mind to assess?

@HumphreyYang
Copy link
Collaborator

Hi @jstac,

I checked the code and the dataset.

The NA values are present because the price index starts from 1919, but other attributes start from 1921.

I agree it does not look great to have all these NAs present.

Would you like me to address this by indexing the price index column, which is the only column we used in the following section?

Many thanks in advance.

@jstac
Copy link
Contributor Author

jstac commented Nov 20, 2023

Yes please @HumphreyYang, or just drop the table all together.

Also, our code should try to stick to max 80 characters per line. Would you mind going through the code and editing accordingly? As you go through, adding a few more comments might be useful too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants