Skip to content

Opening the home folder on macOS generates prompt to allow access to iCloud Drive, Reminders etc. #4814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
6 tasks done
craftzneko opened this issue Oct 31, 2023 · 8 comments · Fixed by PowerShell/PowerShellEditorServices#2096
Assignees
Labels
Area-Script Analysis Issue-Bug A bug to squash. Needs: Fix Verification Please verify the fix for us! Resolution-Fixed Will close automatically.

Comments

@craftzneko
Copy link

Prerequisites

  • I have written a descriptive issue title.
  • I have searched all open and closed issues to ensure it has not already been reported.
  • I have read the troubleshooting guide.
  • I am sure this issue is with the extension itself and does not reproduce in a standalone PowerShell instance.
  • I have verified that I am using the latest version of Visual Studio Code and the PowerShell extension.
  • If this is a security issue, I have read the security issue reporting guidance.

Summary

isolated a prompt that vs code requests access to iCloud data drive and reminders, why is It trying to access my reminders?

Screenshot 2023-10-25 at 23 03 11 Screenshot 2023-10-31 at 23 51 31

PowerShell Version

Name                           Value
----                           -----
PSVersion                      7.3.9
PSEdition                      Core
GitCommitId                    7.3.9
OS                             Darwin 23.0.0 Darwin Kernel Version 23.0.0: Fri…
Platform                       Unix
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

Visual Studio Code Version

Version: 1.83.1 (Universal)
Commit: f1b07bd25dfad64b0167beb15359ae573aecd2cc
Date: 2023-10-10T23:46:55.789Z (3 wks ago)
Electron: 25.8.4
ElectronBuildId: 24154031
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: 11.4.183.29-electron.0
OS: Darwin arm64 23.0.0

Extension Version

v2023.8.0

Steps to Reproduce

run powershell extension added to vs code, powershelgl installed via home-brew

Visuals

No response

Logs

No response

@craftzneko craftzneko added the Issue-Bug A bug to squash. label Oct 31, 2023
@SydneyhSmith
Copy link
Collaborator

This may be related to #4821 , does this reproduce without the PowerShell extension?

@SydneyhSmith
Copy link
Collaborator

@craftzneko are you in a workspace?

@craftzneko
Copy link
Author

@SydneyhSmith I was not in a workspace, hopefully above resolves.

@andyleejordan
Copy link
Member

This should be resolved in the next pre-release. The bug was that if no workspace folder was given, we added the initial working directory (often the home directory, as that was the final fallback but also what many users set the cwd setting to) as the "first" workspace. That's obviously wrong given that it would trigger enumeration of all files under that folder. Instead we just let the list of workspace folders be empty, so if you haven't opened a workspace, no files will be enumerated (for symbol analysis).

@andyleejordan andyleejordan self-assigned this Nov 10, 2023
@andyleejordan andyleejordan moved this to Done in Flying Fox Nov 10, 2023
@andyleejordan andyleejordan changed the title running on Mac OS Sonoma generates prompt to allow access to iCloud/reminders Opening the home folder on macOS generates prompt to allow access to iCloud Drive, Reminders etc. Nov 10, 2023
@andyleejordan andyleejordan reopened this Dec 7, 2023
@andyleejordan andyleejordan added Needs: Fix Verification Please verify the fix for us! Resolution-Fixed Will close automatically. labels Dec 7, 2023
@andyleejordan
Copy link
Member

Re-opening and asking if you can verify for us that it's fixed in the upcoming pre-release (which I will try to get out tomorrow).

@github-actions github-actions bot added Needs: Maintainer Attention Maintainer attention needed! and removed Needs: Fix Verification Please verify the fix for us! labels Dec 7, 2023
@andyleejordan andyleejordan added Needs: Fix Verification Please verify the fix for us! and removed Needs: Maintainer Attention Maintainer attention needed! labels Dec 7, 2023
@craftzneko
Copy link
Author

@andyleejordan happy to try, is the pre release out

@github-actions github-actions bot added Needs: Maintainer Attention Maintainer attention needed! and removed Needs: Fix Verification Please verify the fix for us! labels Dec 8, 2023
@andyleejordan
Copy link
Member

It's going out right now!

@andyleejordan andyleejordan added Needs: Fix Verification Please verify the fix for us! and removed Needs: Maintainer Attention Maintainer attention needed! labels Dec 11, 2023
Copy link
Contributor

This issue has been labeled as needing fix verification and has not had any activity a week. It has been closed for housekeeping purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Script Analysis Issue-Bug A bug to squash. Needs: Fix Verification Please verify the fix for us! Resolution-Fixed Will close automatically.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants