Skip to content

Integrated Console fails to load when Newtonsoft.Json fails to parse valid settings.json #2812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brettpostin opened this issue Jul 17, 2020 · 2 comments
Labels
Resolution-Duplicate Will close automatically.

Comments

@brettpostin
Copy link

Issue Description

With the following in settings.json:

    "files.exclude": {
        "**/*.js": {"when": "$(basename).ts"}
    },

The PowerShell Integrated Console fails to load, it just hangs before reaching the command prompt. Removing the above setting fixes the issue, however it is a valid setting to hide generated .js files in a typescript project.

Logs

In EditorServices.log:

2020-07-17 12:25:19.294 +01:00 [FTL] Failed to handle request workspace/didChangeConfiguration
Newtonsoft.Json.JsonReaderException: Error reading boolean. Unexpected token: StartObject. Path 'files.exclude['**/*.js']'.

Environment Information

Visual Studio Code

Name Version
Operating System Windows_NT x64 10.0.19041
VSCode 1.47.2
PowerShell Extension Version 2020.6.0

PowerShell Information

Name Value
PSVersion 5.1.19041.1
PSEdition Desktop
PSCompatibleVersions 1.0 2.0 3.0 4.0 5.0 5.1.19041.1
BuildVersion 10.0.19041.1
CLRVersion 4.0.30319.42000
WSManStackVersion 3.0
PSRemotingProtocolVersion 2.3
SerializationVersion 1.1.0.1

Visual Studio Code Extensions

Visual Studio Code Extensions(Click to Expand)
Extension Author Version
azure-account ms-vscode 0.8.11
csharp ms-dotnettools 1.22.1
powershell ms-vscode 2020.6.0
sonarlint-vscode SonarSource 1.16.0
vscode-azurefunctions ms-azuretools 0.23.0
vscode-typescript-tslint-plugin ms-vscode 1.2.3
vsliveshare ms-vsliveshare 1.0.2427
@ghost ghost added the Needs: Triage Maintainer attention needed! label Jul 17, 2020
@brettpostin brettpostin changed the title Integrated Console fails to load when Newtonsoft.Json fails to parse valid settings Integrated Console fails to load when Newtonsoft.Json fails to parse valid settings.json Jul 17, 2020
@rjmholt
Copy link
Contributor

rjmholt commented Jul 20, 2020

Duplicate of #2658

@rjmholt rjmholt marked this as a duplicate of #2658 Jul 20, 2020
@rjmholt rjmholt added Resolution-Duplicate Will close automatically. and removed Needs: Triage Maintainer attention needed! labels Jul 20, 2020
@ghost
Copy link

ghost commented Jul 22, 2020

This issue has been marked as duplicate and has not had any activity for 1 day. It has been closed for housekeeping purposes.

@ghost ghost closed this as completed Jul 22, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution-Duplicate Will close automatically.
Projects
None yet
Development

No branches or pull requests

2 participants