Skip to content

Number sign in path breaks highlighting #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost opened this issue Apr 19, 2016 · 6 comments
Closed

Number sign in path breaks highlighting #150

ghost opened this issue Apr 19, 2016 · 6 comments
Labels
Issue-Bug A bug to squash.

Comments

@ghost
Copy link

ghost commented Apr 19, 2016

When a number sign is part of a path, the highlighting breaks for everything on that line after the number sign.

Here's how it looks with a number sign:
bad

And If I delete the number sign, it works again.
good

@rkeithhill
Copy link
Contributor

Hmm, looks like the tm definition of single line comments isn't quite right. IIRC a comment char # must have at least one (non-escaped) whitespace char in front of it. Or it must be at the beginning of a line.

@daviwil
Copy link
Contributor

daviwil commented Apr 25, 2016

We'll need to fix this for the shared syntax definition. Really need to get the repo created for that...

@daviwil daviwil added this to the Backlog milestone Apr 25, 2016
@TylerLeonhardt
Copy link
Member

You mean this repo, @daviwil 😄

@rkeithhill
Copy link
Contributor

Yeah, this issue should be moved to that repo - if it's still an issue (I suspect it is).

@TylerLeonhardt
Copy link
Member

It is, for the record

@TylerLeonhardt
Copy link
Member

Opened there so I'll close it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug A bug to squash.
Projects
None yet
Development

No branches or pull requests

3 participants