Add handlers to cleanup dotnet attach

Author: JustinGrote

src/features/DebugSession.ts

@@ -11,6 +11,7 @@ import {
     DebugConfiguration,
     DebugConfigurationProvider,
     DebugSession,
+    Disposable,
     ExtensionContext,
     WorkspaceFolder
 } from "vscode";
@@ -92,7 +93,7 @@ export class DebugSessionFeature extends LanguageClientConsumer
 
         if (sessionDetails === undefined) {
             void this.logger.writeAndShowError(`PowerShell session details not available for ${session.name}`);
-            return;
+            return undefined;
         }
 
         this.logger.writeVerbose(`Connecting to pipe: ${sessionDetails.debugServicePipeName}`);
@@ -149,6 +150,26 @@ export class DebugSessionFeature extends LanguageClientConsumer
                 return undefined;
             }
 
+            // Wire up a handler to capture the dotnet session and stop it before PowerShell, otherwise it will emit an error that its process unexpectedly stopped.
+            let dotnetAttachStartHandler: Disposable[] = []
+            vscode.debug.onDidStartDebugSession((dotnetAttachSession) => {
+                this.logger.write(`Debugger session detected: ${dotnetAttachSession.name} (${dotnetAttachSession.id})`);
+                let dotnetAttachStopHandler: Disposable[] = [];
+                if (dotnetAttachSession.configuration.name == dotnetDebuggerConfig.name) {
+                    vscode.debug.onDidTerminateDebugSession(async (terminatedDebugSession) => {
+                        this.logger.write(`Debugger session stopped: ${terminatedDebugSession.name} (${terminatedDebugSession.id})`);
+                        if (terminatedDebugSession === session) {
+                            this.logger.write("Terminating dotnet debugger session associated with PowerShell debug session");
+                            await vscode.debug.stopDebugging(dotnetAttachSession);
+                        }
+                        //This makes it a one time event
+                        dotnetAttachStopHandler.forEach((handler) => handler.dispose());
+                    }, undefined, dotnetAttachStopHandler);
+                }
+                //This makes it a one time event
+                dotnetAttachStartHandler.forEach((handler) => handler.dispose());
+            }, undefined, dotnetAttachStartHandler);
+
             // Start a child debug session to attach the dotnet debugger
             // TODO: Accomodate multi-folder workspaces if the C# code is in a different workspace folder
             await vscode.debug.startDebugging(undefined, dotnetDebuggerConfig, session);
@@ -169,11 +190,15 @@ export class DebugSessionFeature extends LanguageClientConsumer
         }
 
         // Default debugger config if none provided
+        // TODO: Type this appropriately from the C# extension?
         return {
             name: "Dotnet Debugger: PSIC Temporary Console",
             type: "coreclr",
             request: "attach",
-            processId: pid
+            processId: pid,
+            logging: {
+                moduleLoad: false
+            }
         };
     }