Skip to content

Commit 3c3d1dd

Browse files
committed
Remove CustomViews feature
This has been broken for at least (probably) a year so its usage is minimal. We're removing it and the associated `PowerShellEditorServices.VSCode` module.
1 parent 6225390 commit 3c3d1dd

File tree

7 files changed

+1
-428
lines changed

7 files changed

+1
-428
lines changed

.vsts-ci/templates/ci-general.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ steps:
9696
targetType: inline
9797
pwsh: true
9898
script: |
99-
$assembly = [Reflection.Assembly]::LoadFile('$(Build.SourcesDirectory)/vscode-powershell/modules/PowerShellEditorServices.VSCode/bin/Microsoft.PowerShell.EditorServices.VSCode.dll')
99+
$assembly = [Reflection.Assembly]::LoadFile("$(Build.SourcesDirectory)/vscode-powershell/modules/PowerShellEditorServices/bin/Core/Microsoft.PowerShell.EditorServices.Hosting.dll")
100100
if ($assembly.GetCustomAttributes([System.Diagnostics.DebuggableAttribute], $true).IsJITOptimizerDisabled) {
101101
Write-Host '##vso[task.LogIssue type=error;]PowerShell Editor Services bits were not built in release configuration!'
102102
exit 1

examples/ContentViewTest.ps1

-8
This file was deleted.

src/features/CustomViews.ts

-269
This file was deleted.

src/main.ts

-2
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ import TelemetryReporter from "@vscode/extension-telemetry";
66
import { DocumentSelector } from "vscode-languageclient";
77
import { CodeActionsFeature } from "./features/CodeActions";
88
import { ConsoleFeature } from "./features/Console";
9-
import { CustomViewsFeature } from "./features/CustomViews";
109
import { DebugSessionFeature } from "./features/DebugSession";
1110
import { ExamplesFeature } from "./features/Examples";
1211
import { ExpandAliasFeature } from "./features/ExpandAlias";
@@ -156,7 +155,6 @@ export async function activate(context: vscode.ExtensionContext): Promise<IPower
156155
new DebugSessionFeature(context, sessionManager, logger),
157156
new PickPSHostProcessFeature(logger),
158157
new HelpCompletionFeature(),
159-
new CustomViewsFeature(),
160158
new PickRunspaceFeature(logger),
161159
externalApi
162160
];

src/session.ts

-1
Original file line numberDiff line numberDiff line change
@@ -709,7 +709,6 @@ export class SessionManager implements Middleware {
709709
"-HostName 'Visual Studio Code Host' " +
710710
"-HostProfileId 'Microsoft.VSCode' " +
711711
`-HostVersion '${this.HostVersion}' ` +
712-
"-AdditionalModules @('PowerShellEditorServices.VSCode') " +
713712
`-BundledModulesPath '${utils.escapeSingleQuotes(bundledModulesPath)}' ` +
714713
"-EnableConsoleRepl ";
715714

0 commit comments

Comments
 (0)