Skip to content

Make Invoke-PSRLConstructor and Invoke-PSRLReadLine exported cmdlets #1296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TylerLeonhardt opened this issue May 24, 2020 · 5 comments
Closed

Make Invoke-PSRLConstructor and Invoke-PSRLReadLine exported cmdlets #1296

TylerLeonhardt opened this issue May 24, 2020 · 5 comments
Labels
Area-Engine Resolution-Duplicate Will close automatically.

Comments

@TylerLeonhardt
Copy link
Member

When in a debug prompt... this PowerShell bug is exposed:
PowerShell/PowerShell#12297

On this line:
https://github.com/PowerShell/PowerShell/blob/9212aac0fa020b657454ef4f9ff2fdd6fc6d759c/src/System.Management.Automation/engine/debugger/debugger.cs#L2360

Since we support 5.1... we have no option here but to revert #1258
@ghost ghost added the Needs: Triage Maintainer attention needed! label May 24, 2020
@TylerLeonhardt TylerLeonhardt changed the title Make Invoke-PSRLConstructor and Invoke-PSRLReadLine CmdletBinding Make Invoke-PSRLConstructor and Invoke-PSRLReadLine exported cmdlets May 24, 2020
@TylerLeonhardt
Copy link
Member Author

This is until #1295 is done.

@ghost ghost added the Needs: Maintainer Attention Maintainer attention needed! label May 24, 2020
@TylerLeonhardt TylerLeonhardt mentioned this issue May 24, 2020
Closed
@SydneyhSmith SydneyhSmith removed Needs: Maintainer Attention Maintainer attention needed! Needs: Triage Maintainer attention needed! labels Jun 11, 2020
@SydneyhSmith SydneyhSmith mentioned this issue Jun 16, 2020
Closed
@ppainter1958
Copy link

ppainter1958 commented Jun 28, 2020 •
edited by rjmholt
Loading

Having same issue as PowerShell/vscode-powershell#2767, any suggested work around or timeframe to fix?

@ghost ghost added the Needs: Maintainer Attention Maintainer attention needed! label Jun 28, 2020
@rjmholt
Copy link
Contributor

rjmholt commented Jun 28, 2020

timeframe to fix

Working on the solution in https://github.com/rjmholt/PowerShellEditorServices/tree/async-ps-consumer, but it's a large work item and will likely require changes in PSReadLine to be released first, so won't be for some time.

@SydneyhSmith SydneyhSmith added Area-Engine and removed Needs: Maintainer Attention Maintainer attention needed! labels Jul 9, 2020
@SydneyhSmith
Copy link
Collaborator

Going to mark this as a duplicate of #1295

@ghost ghost added the Needs: Maintainer Attention Maintainer attention needed! label Jul 9, 2020
@SydneyhSmith SydneyhSmith added Resolution-Duplicate Will close automatically. and removed Needs: Maintainer Attention Maintainer attention needed! labels Jul 9, 2020
@ghost
Copy link

ghost commented Jul 10, 2020

This issue has been marked as duplicate and has not had any activity for 1 day. It will be closed for housekeeping purposes.

@ghost ghost closed this as completed Jul 10, 2020
@ili101 ili101 mentioned this issue Aug 17, 2020
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Engine Resolution-Duplicate Will close automatically.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@TylerLeonhardt @ppainter1958 @rjmholt @SydneyhSmith