Skip to content

Duplicate code in sequence - may cause error. Possible error in merge conflict resolution. #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
chenho74 opened this issue May 12, 2023 · 1 comment · May be fixed by #609
Open

Duplicate code in sequence - may cause error. Possible error in merge conflict resolution. #608

chenho74 opened this issue May 12, 2023 · 1 comment · May be fixed by #609
Labels
bug Something isn't working

Comments

@chenho74
Copy link

Branch/Tag/Commit

main

Docker Image Version

n/a

GPU name

n/a

CUDA Driver

n/a

Reproduced Steps

https://github.com/NVIDIA/FasterTransformer/blob/c6e8f60ec40da218804a60e6aa986903e7fa8594/src/fastertransformer/layers/attention_layers/GptContextAttentionLayer.cc#L568-L582
@chenho74 chenho74 added the bug Something isn't working label May 12, 2023
@chenho74
Copy link
Author

should be a quick fix if it is indeed an error. Just need to remove the redundant 7 lines.

@chenho74 chenho74 linked a pull request May 12, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove buggy duplicated code chenho74/FasterTransformer
1 participant
@chenho74