runtime: do not allow runroot longer than 50 characters

giuseppe · giuseppe · commit c65b3599cc3a · 2018-10-30T15:35:24.000+01:00
Signed-off-by: Giuseppe Scrivano &lt;gscrivan@redhat.com&gt;
diff --git a/cmd/podman/libpodruntime/runtime.go b/cmd/podman/libpodruntime/runtime.go
@@ -5,6 +5,7 @@ import (
 	"github.com/containers/libpod/pkg/rootless"
 	"github.com/containers/libpod/pkg/util"
 	"github.com/containers/storage"
+	"github.com/pkg/errors"
 	"github.com/urfave/cli"
 )
 
@@ -42,6 +43,9 @@ func GetRuntimeWithStorageOpts(c *cli.Context, storageOpts *storage.StoreOptions
 	if c.GlobalIsSet("runroot") {
 		storageOpts.RunRoot = c.GlobalString("runroot")
 	}
+	if len(storageOpts.RunRoot) > 50 {
+		return nil, errors.New("the specified runroot is longer than 50 characters")
+	}
 	if c.GlobalIsSet("storage-driver") {
 		storageOpts.GraphDriverName = c.GlobalString("storage-driver")
 	}

Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,7 @@ import (`
`5`	`5`	`"github.com/containers/libpod/pkg/rootless"`
`6`	`6`	`"github.com/containers/libpod/pkg/util"`
`7`	`7`	`"github.com/containers/storage"`
	`8`	`+ "github.com/pkg/errors"`
`8`	`9`	`"github.com/urfave/cli"`
`9`	`10`	`)`
`10`	`11`
`@@ -42,6 +43,9 @@ func GetRuntimeWithStorageOpts(c cli.Context, storageOpts storage.StoreOptions`
`42`	`43`	`if c.GlobalIsSet("runroot") {`
`43`	`44`	`storageOpts.RunRoot = c.GlobalString("runroot")`
`44`	`45`	`}`
	`46`	`+ if len(storageOpts.RunRoot) > 50 {`
	`47`	`+ return nil, errors.New("the specified runroot is longer than 50 characters")`
	`48`	`+ }`
`45`	`49`	`if c.GlobalIsSet("storage-driver") {`
`46`	`50`	`storageOpts.GraphDriverName = c.GlobalString("storage-driver")`
`47`	`51`	`}`