Skip to content

Make it possible to customize the shortcuts in editor #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Leslie-Wong-H opened this issue May 30, 2019 · 3 comments · Fixed by #340
Closed

Make it possible to customize the shortcuts in editor #335

Leslie-Wong-H opened this issue May 30, 2019 · 3 comments · Fixed by #340
Labels
enhancement New feature or request
Milestone

Comments

@Leslie-Wong-H
Copy link

Now the latest version of vscode-leetcode adds solution shortcut to the answer file window, yet does not provide a setting to hide the solution shortcut. In my own experience, the solution shortcut is somehow disturbing, forcing me to click it more or less. That's really not good when I try to solve the problem by my own.

I look through the leetcode settings, only to find Leetcode: Enable Shortcuts ( Show the submit and test shortcuts in editor or not. ) . Hence, It 's necessary to add setting -- Leetcode: Hide Solution Shortcut.

@jdneo
Copy link
Member

jdneo commented May 30, 2019

Thank you for the feedback. Let me think about if we can have a way to let the user customize the shortcuts by his own. Like, make the configuration become an array:

leetcode.editor.shortcuts: [
    "test",
    "submit",
]

something like that.

Feel free to let me know your thoughts.

@jdneo jdneo added the enhancement New feature or request label May 30, 2019
@Leslie-Wong-H
Copy link
Author

Thank you for the feedback. Let me think about if we can have a way to let the user customize the shortcuts by his own. Like, make the configuration become an array:
leetcode.shortcuts: [
"test",
"submit",
]

something like that.
Feel free to let me know your thoughts.

Sounds like a reasonable proposal.

@jdneo jdneo changed the title add setting -- Leetcode: hide solution shortcut Make it possible to customize the shortcuts in editor May 31, 2019
@jdneo jdneo added this to the 0.14.4 milestone Jun 3, 2019
@jdneo
Copy link
Member

jdneo commented Jun 3, 2019

I'll start working on this these days.

Note: After adopting this setting, the leetcode.enableShortcuts will be deprecated. If you want to disable the shortcuts, just set leetcode.editor.shortcuts to []

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants