feat: add .nvmrc and engines key to package.json

[Pinjasaur]

PR Checklist

• Addresses an existing open issue: fixes 🛠 Tooling: Add an .nvmrc and package.json engines #65
• That issue was marked as accepting prs
• Steps in CONTRIBUTING.md were taken

Overview

It's like JoshuaKGoldberg/refined-saved-replies#69 but for this repo. 🙃

[JoshuaKGoldberg]

This looks great in general (thanks for sending it! ✨), but it's failing a lint task:

$ npx eslint . --max-warnings 0 --report-unused-disable-directives

template-typescript-node-package/package.json
Error:   51:2  error  Expected object keys to be in ascending order. 'engines' should be before 'version'  jsonc/sort-keys

This is one of the lint rules I've been meaning to bring into my other repos 😄

[JoshuaKGoldberg]

💯 thanks!

[Pinjasaur]

Thanks @JoshuaKGoldberg! Would it be worth adding to a precommit hook locally? I personally have a tendency to "commit and forget."

[github-actions]

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

[JoshuaKGoldberg]

What would the precommit hook do?

I'm wary of running ESLint in a hook because with type information it can be a little slow. But if there's a good way to only run untyped + fixable rules, that'd be nice...

[Pinjasaur]

What would the precommit hook do?

I'm wary of running ESLint in a hook because with type information it can be a little slow. But if there's a good way to only run untyped + fixable rules, that'd be nice...

I was just thinking it could lint. 🤷🏻

I've used lint-staged on a project at a previous role and it was pretty slick, even ended up using it to leverage shellcheck to lint shell scripts in the same (mono)repo. Maybe it would be worth a test/benchmark? 🙂

[JoshuaKGoldberg]

If a benchmark shows it's reasonably quick, I'm down!

We'll want to get a meaty project in. tslint-to-eslint-config might be a good testing ground.

[JoshuaKGoldberg]

@allcontributors add @Pinjasaur for tooling

(whoops, sorry, I forgot I'd set this up!)

[allcontributors]

@JoshuaKGoldberg

I've put up a pull request to add @Pinjasaur! 🎉