Skip to content

Commit 17fc97f

Browse files
committed
apply feedback from pr review
1 parent 02d0b1b commit 17fc97f

File tree

2 files changed

+2
-8
lines changed

2 files changed

+2
-8
lines changed

src/fastapi_app/dependencies.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -109,13 +109,7 @@ async def get_async_db_session(
109109
sessionmaker: Annotated[async_sessionmaker[AsyncSession], Depends(get_async_sessionmaker)],
110110
) -> AsyncGenerator[AsyncSession, None]:
111111
async with sessionmaker() as session:
112-
try:
113-
yield session
114-
except:
115-
await session.rollback()
116-
raise
117-
else:
118-
await session.commit()
112+
yield session
119113

120114

121115
async def get_openai_chat_client(

src/fastapi_app/routes/api_routes.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313

1414

1515
@router.get("/items/{id}", response_model=ItemPublic)
16-
async def item_handler(id: int, database_session: DBSession) -> ItemPublic:
16+
async def item_handler(database_session: DBSession, id: int) -> ItemPublic:
1717
"""A simple API to get an item by ID."""
1818
item = (await database_session.scalars(select(Item).where(Item.id == id))).first()
1919
if not item:

0 commit comments

Comments
 (0)